From owner-freebsd-current@FreeBSD.ORG Tue Mar 12 08:04:47 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 82FE0519 for ; Tue, 12 Mar 2013 08:04:47 +0000 (UTC) (envelope-from SNasonov@BCC.RU) Received: from extmx.bcc.ru (extmx.bcc.ru [217.170.85.214]) by mx1.freebsd.org (Postfix) with ESMTP id BDBA4F39 for ; Tue, 12 Mar 2013 08:04:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by extmx.bcc.ru (Postfix) with ESMTP id D3B8816011; Tue, 12 Mar 2013 12:04:33 +0400 (GMT-4) Received: from extmx.bcc.ru ([127.0.0.1]) by localhost (extmx.bcc.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 30817-04; Tue, 12 Mar 2013 12:04:28 +0400 (GMT-4) Received: from mail.bcc (unknown [172.16.250.23]) by extmx.bcc.ru (Postfix) with ESMTP id A54E013562; Tue, 12 Mar 2013 12:04:28 +0400 (GMT-4) Received: from snasonovnbwxp.bcc ([192.168.201.205]) by mail.bcc over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 12 Mar 2013 12:04:32 +0400 From: Sergey Nasonov To: freebsd-current@freebsd.org Subject: Re: Headphone support on Thinkpad T430s Date: Tue, 12 Mar 2013 12:04:25 +0400 Message-ID: <1584949.6vl9dv5U6v@snasonovnbwxp.bcc> Organization: BCC User-Agent: KMail/4.9.5 (FreeBSD/9.1-STABLE; KDE/4.9.5; amd64; ; ) In-Reply-To: <513ED49B.4060503@gmail.com> References: <513ED49B.4060503@gmail.com> MIME-Version: 1.0 X-OriginalArrivalTime: 12 Mar 2013 08:04:32.0975 (UTC) FILETIME=[3AEE6DF0:01CE1EF8] X-Virus-Scanned: amavisd-new at bcc.ru Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Johannes Dieterich X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2013 08:04:47 -0000 I have T430 and to get headphone working I am using following workaround: hint.hdaa.4.nid21.config="as=1 seq=15" in /boot/device.hints So the final patch should looks like this Index: sys/dev/sound/pci/hda/hdaa_patches.c =================================================================== --- sys/dev/sound/pci/hda/hdaa_patches.c (revision 248186) +++ sys/dev/sound/pci/hda/hdaa_patches.c (working copy) @@ -344,7 +344,8 @@ break; } } else if (id == HDA_CODEC_ALC269 && - subid == LENOVO_X1CRBN_SUBVENDOR) { + (subid == LENOVO_X1CRBN_SUBVENDOR || + subid == LENOVO_T430_SUBVENDOR || + subid == LENOVO_T430S_SUBVENDOR)) { switch (nid) { case 21: patch = "as=1 seq=15"; Index: sys/dev/sound/pci/hda/hdac.h =================================================================== --- sys/dev/sound/pci/hda/hdac.h (revision 248186) +++ sys/dev/sound/pci/hda/hdac.h (working copy) @@ -218,13 +218,14 @@ #define LENOVO_VENDORID 0x17aa #define LENOVO_3KN100_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x2066) #define LENOVO_3KN200_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x384e) -#define LENOVO_B450_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x3a0d) +#define LENOVO_B450_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x3a0d) #define LENOVO_TCA55_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x1015) #define LENOVO_X1_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21e8) #define LENOVO_X1CRBN_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21f9) #define LENOVO_X220_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21da) #define LENOVO_X300_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x20ac) #define LENOVO_T420_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21ce) +#define LENOVO_T430_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21f3) +#define LENOVO_T430S_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21fb) #define LENOVO_T520_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21cf) #define LENOVO_ALL_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0xffff) On Tuesday 12 March 2013 03:09:15 Johannes Dieterich wrote: > Dear list, > > please see a patch to enable proper headphone support on Thinkpad T430s > models. The quirk uses the same logic as the recent patch to CURRENT to > enable some other Thinkpad models. Unfortunately, I cannot comment if > this will work for other models (such as the regular T430) as well, > therefore I used the T430S identifier. > > Hope someone can commit this, > > Johannes -- Best Regards, Nasonov Sergey