Date: Fri, 16 Aug 2002 10:40:03 -0700 (PDT) From: Christian Weisgerber <naddy@mips.inka.de> To: freebsd-ports@FreeBSD.org Subject: Re: ports/41710: [port] lame update (fix CFLAGS) Message-ID: <200208161740.g7GHe3MF037907@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/41710; it has been noted by GNATS. From: Christian Weisgerber <naddy@mips.inka.de> To: lioux@FreeBSD.org Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: ports/41710: [port] lame update (fix CFLAGS) Date: Fri, 16 Aug 2002 18:44:25 +0200 (CEST) In article <200208161520.g7GFK3Cq017168@freefall.freebsd.org> you write: > What about making patch optional? I mean, > if the user adds WITH_OPTIMIZED_CFLAGS, this patch is not applied. > Otherwise, it is applied per default. What's the gain? The whole point of making a port honor CFLAGS is that users can set them at their convenience. If somebody wants to build lame with super-duper optimization flags, they can just do so with $ CFLAGS="-O1000 -mfoo -fbar" make build (Personally, I'd go for something like CC=ccc CFLAGS=-fast.) > Check audio/liba52/Makefile for an example. Truly pointless, IMO. -- Christian "naddy" Weisgerber naddy@mips.inka.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200208161740.g7GHe3MF037907>