From owner-cvs-all Sun Jan 7 23:14:45 2001 Delivered-To: cvs-all@freebsd.org Received: from earth.backplane.com (placeholder-dcat-1076843399.broadbandoffice.net [64.47.83.135]) by hub.freebsd.org (Postfix) with ESMTP id 4D88B37B6A1; Sun, 7 Jan 2001 23:09:01 -0800 (PST) Received: (from dillon@localhost) by earth.backplane.com (8.11.1/8.9.3) id f0878ho23507; Sun, 7 Jan 2001 23:08:43 -0800 (PST) (envelope-from dillon) Date: Sun, 7 Jan 2001 23:08:43 -0800 (PST) From: Matt Dillon Message-Id: <200101080708.f0878ho23507@earth.backplane.com> To: Greg Lehey Cc: Soren Schmidt , Will Andrews , =?iso-8859-1?Q?S=F8ren_Schmidt?= , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: please do not close the drive tray automatically. (was Re: cvs commit: src/sys/dev/ata atapi-cd.c) References: <20010107115456.S1611@puck.firepipe.net> <200101071658.RAA05273@freebsd.dk> <20010108092141.L52707@wantadilla.lemis.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Umm. I'm going to be a pest: If the drive tray is open the very LAST thing I want is for the device driver to try to close it on me. A windows box *destroyed* a CD (by scratching the hell out of it) that I was trying to insert into the machine by closing the drive tray before I had the CD completely seated. I do not want the same to happen under FreeBSD just because some program (say, like sysinstall) tries to open the CD device. -Matt :> It seems Will Andrews wrote: :>> On Sun, Jan 07, 2001 at 08:50:53AM -0800, Søren Schmidt wrote: :>>> Log: :>>> MFC: :>>> On open try to close the drivetray and wait for drive ready. :>> :>> Uhm, immediate MFC? :> :> No there was almost 2 mins between those :) :> :> Seriously this patch is so simple I deemed this trivial enough to :> put in right away, I even asked the MAINTAINER :) : :-core has had an official complaint about instant MFCs (not this one). :We haven't come to any conclusion, but I'm pretty sure that when we :do, we wouldn't condone this kind of thing. : :Greg To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message