From owner-freebsd-current@FreeBSD.ORG  Thu Jul 29 18:21:48 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2620416A4CE; Thu, 29 Jul 2004 18:21:48 +0000 (GMT)
Received: from sakura.ninth-nine.com (sakura.ninth-nine.com [219.127.74.120])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A248543D2D; Thu, 29 Jul 2004 18:21:47 +0000 (GMT)
	(envelope-from nork@FreeBSD.org)
Received: from nadesico.ninth-nine.com (nadesico.ninth-nine.com
	[219.127.74.122]) by sakura.ninth-nine.com (8.12.11/8.12.11/NinthNine) with
	ESMTP id i6TILkpN040159; Fri, 30 Jul 2004 03:21:46 +0900 (JST) (envelope-from
	nork@FreeBSD.org)
Date: Fri, 30 Jul 2004 03:21:46 +0900
From: Norikatsu Shigemura <nork@FreeBSD.org>
To: Robert Watson <rwatson@FreeBSD.org>
Message-Id: <20040730032146.2f58c73c.nork@FreeBSD.org>
In-Reply-To: <Pine.NEB.3.96L.1040729123927.46374E-100000@fledge.watson.org>
References: <200407291639.i6TGdIP5037477@sakura.ninth-nine.com>
	<Pine.NEB.3.96L.1040729123927.46374E-100000@fledge.watson.org>
X-Mailer: Sylpheed version 0.9.12-gtk2-20040622 (GTK+ 2.4.4;
	i386-portbld-freebsd5.2)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.3
	(sakura.ninth-nine.com [219.127.74.121]); Fri, 30 Jul 2004 03:21:46 +0900
	(JST)
cc: freebsd-current@FreeBSD.org
cc: nork@FreeBSD.org
Subject: Re: rip6_output WITNESS warning
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2004 18:21:48 -0000

On Thu, 29 Jul 2004 12:40:46 -0400 (EDT)
Robert Watson <rwatson@FreeBSD.org> wrote:
> > 	I contacted WITNESS warning on boot(newest current) in my
> > 	SMP machine(PentiumIII x2).
> Similar to a problem we saw on IPv4.  Could you try the following:
> - At or about line 379 of raw_ip6.c (raw6_output()), there's a call to
>   M_PREPEND with the argumetn M_TRYWAIT.  Could you make this M_DONTWAIT?
> - This code fails to properly check the return value.  After the
>   M_PREPEND() call, we should check if m is NULL, and if so, goto bad.

	Thanks for ume's suggestion.  I modified it like following
	lines:
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
	M_PREPEND(m, sizeof(*ip6), M_DONTWAIT);
	if (m == NULL) {
		error = ENOBUFS;
		goto bad;
	}
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
	I rebooted and, at least, I didn't contact WITNESS warning.
	I think it looks good...