Date: Fri, 25 Aug 2017 10:16:47 +0200 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: Warner Losh <imp@FreeBSD.org> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r322863 - head/sys/cam Message-ID: <20170825101647.5a385e1c@fabiankeil.de> In-Reply-To: <201708242211.v7OMBAlc012582@repo.freebsd.org> References: <201708242211.v7OMBAlc012582@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/LWaf+IfUL2+zVwlmID+qDJV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Warner Losh <imp@FreeBSD.org> wrote: > Author: imp > Date: Thu Aug 24 22:11:10 2017 > New Revision: 322863 > URL: https://svnweb.freebsd.org/changeset/base/322863 >=20 > Log: > Expand the latency tracking array from 1.024s to 8.192s to help track > extreme outliers from dodgy drives. Adjust comments to reflect this, > and make sure that the number of latency buckets match in the two > places where it matters. It also matters for the sysctl description in cam_iosched_iop_stats_sysctl_= init(). Would you mind increasing LAT_BUCKETS a bit more? I've recently set it to 17 in ElectroBSD as writes to my laptop's disk occasionally take a while under load: fk@t520 ~ $sudo /usr/src/share/dtrace/bio-request-latency [...] ada0 BIO_WRITE value ------------- Distribution ------------- count 16 | 0 32 | 1 64 | 34 128 |@ 582 256 |@@@@@@@@@@ 10608 512 |@@@@@ 5574 1024 |@@ 2454 2048 |@@@@ 3872 4096 |@@@@ 4043 8192 |@@@@ 4115 16384 |@@@@@ 4953 32768 |@@@ 3656 65536 |@@ 2252 131072 |@ 764 262144 | 331 524288 | 291 1048576 | 53 2097152 | 9 4194304 | 4 8388608 | 6 16777216 | 2 33554432 | 0 ada0 BIO_READ value ------------- Distribution ------------- count 16 | 0 32 | 1 64 | 126 128 |@ 1205 256 |@@@@@ 6359 512 |@@@ 3987 1024 |@@ 2044 2048 |@ 1384 4096 |@@ 2853 8192 |@@@@@ 6012 16384 |@@@@@@ 7254 32768 |@@@@@ 6524 65536 |@@@@ 4945 131072 |@@@ 3006 262144 |@ 1194 524288 |@ 620 1048576 | 162 2097152 | 0 Disk Bio Type Requests | Latency in us = | iops Throughput | avg stddev max min | ada0 BIO_FLUSH 253 | 145927 162796 1253731 10293 = | 0 0 k/s ada0 BIO_WRITE 43604 | 30345 261090 30069820 61 = | 43 1994 k/s ada0 BIO_READ 47676 | 56039 128083 1691813 63 = | 47 1260 k/s While proper tuning helps, the latency stats are also useful on systems where the iosched limiters haven't been enabled (yet). Fabian --Sig_/LWaf+IfUL2+zVwlmID+qDJV Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTKUNd6H/m3+ByGULIFiohV/3dUnQUCWZ/c7wAKCRAFiohV/3dU nfxrAKCfoLPKVLoyATS9U5izZE90l/nPEACgvaCQaQqjVi0JDYeb/ULD7gwcEQ0= =ZKXA -----END PGP SIGNATURE----- --Sig_/LWaf+IfUL2+zVwlmID+qDJV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170825101647.5a385e1c>