From owner-freebsd-virtualization@FreeBSD.ORG  Wed Oct 29 02:58:33 2014
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 71082684
 for <freebsd-virtualization@freebsd.org>; Wed, 29 Oct 2014 02:58:33 +0000 (UTC)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mx1.redhat.com",
 Issuer "DigiCert SHA2 Extended Validation Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47742E96
 for <freebsd-virtualization@freebsd.org>; Wed, 29 Oct 2014 02:58:33 +0000 (UTC)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9T2wVA6004649
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);
 Tue, 28 Oct 2014 22:58:32 -0400
Received: from [10.3.234.242] (vpn-234-242.phx2.redhat.com [10.3.234.242])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 s9T2wUZG013572; Tue, 28 Oct 2014 22:58:31 -0400
Message-ID: <545057D6.1010402@redhat.com>
Date: Wed, 29 Oct 2014 03:58:30 +0100
From: Michal Privoznik <mprivozn@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Conrad Meyer <cse.cem@gmail.com>
Subject: Re: [libvirt] [PATCH 1/2] bhyve: Support /domain/bootloader
 configuration for non-FreeBSD guests.
References: <1414094284-29055-1-git-send-email-cse.cem@gmail.com>	<1414094284-29055-2-git-send-email-cse.cem@gmail.com>	<54503292.9040907@redhat.com>
 <CAG6CVpWSGcHR2jU7zCsm8OP584dR2Pt7WHOV5KyQUy9Lpq+8tg@mail.gmail.com>
In-Reply-To: <CAG6CVpWSGcHR2jU7zCsm8OP584dR2Pt7WHOV5KyQUy9Lpq+8tg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
Cc: libvir-list@redhat.com,
 "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org>
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization/>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Oct 2014 02:58:33 -0000

On 29.10.2014 02:01, Conrad Meyer wrote:
>> I don't think it's safe to pass arbitrary arguments from XML. I find this
>> too critical to ACK the patch, buy maybe further discussion can change my
>> mind.
>
> Michal,
>
> You're reviewing a 4-revision old version of this patch, see v5 for
> the most recent set. However, this bit is still present in v5. What is
> <bootloader_args> in the XML is for, if not arbitrary arguments?
>

Oh right. I was getting through a lot of e-mails and I didn't notice 
you've posted v5. And yes, you're right - <bootloader_args/> is designed 
for that. Okay then. Let me see how v5 went.

Michal