From owner-svn-src-head@freebsd.org Sat Dec 9 04:57:44 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14343EA0AC0; Sat, 9 Dec 2017 04:57:44 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-io0-f174.google.com (mail-io0-f174.google.com [209.85.223.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E9DE769D5; Sat, 9 Dec 2017 04:57:43 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-io0-f174.google.com with SMTP id e204so4474046iof.12; Fri, 08 Dec 2017 20:57:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ez/wrVTtV/q3A1INAIAFBRNeaUxF8+fpIwqvQYdOhJE=; b=k/p9AVofkxy4VGUFb9QthPaTomp46pGwenC+ndldEwhyzGyiQarLKO2aRh3sRu8Cji laFiTn1AuBKaO+sLt+RRV8IvWi4Iv4pW6MCcsyvd7LnZHVKuQqXNc1YZ77dTR2Aifr+m AlB+k2sY7GNvjezUXAJGkNm7yUssEBF1abnA/Vk2cqcm/tnbquITPBwIhDkDRvmbVntR GfvivXw+yV896pUWXe19L4y55auxKE7bNXS1axhogik3ldsfFcKfxMwouE/U7wGyO01S 1Pp5lFMA8OY5hpKNe204/oVgUVQbTa2Rfn1XMufjmHlldcsWfT8rLn5sDOu4Tx3M43pH gaBQ== X-Gm-Message-State: AJaThX7PKnaSqaTMaPUh7DG8sM4jj/t6KF5IFtqHkSOofiheoMO6gP1y GsP8rU4ESvtyHSi5jiWYR7EHQvzK X-Google-Smtp-Source: AGs4zMZybjw6FOjPhCCr92/jYeUI+dWFAygh+bOve2CoH3juLcxX1I8hc1tOIiY+KDL3Zvv0zLMhSQ== X-Received: by 10.107.169.209 with SMTP id f78mr43302473ioj.162.1512789376974; Fri, 08 Dec 2017 19:16:16 -0800 (PST) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com. [209.85.223.180]) by smtp.gmail.com with ESMTPSA id r125sm1449925iod.74.2017.12.08.19.16.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Dec 2017 19:16:16 -0800 (PST) Received: by mail-io0-f180.google.com with SMTP id v186so4361869iod.7; Fri, 08 Dec 2017 19:16:15 -0800 (PST) X-Received: by 10.107.114.19 with SMTP id n19mr5216971ioc.224.1512789375486; Fri, 08 Dec 2017 19:16:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.164.151 with HTTP; Fri, 8 Dec 2017 19:16:14 -0800 (PST) Received: by 10.107.164.151 with HTTP; Fri, 8 Dec 2017 19:16:14 -0800 (PST) In-Reply-To: References: <201712082011.vB8KBUsA068552@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Fri, 8 Dec 2017 21:16:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee To: Eitan Adler Cc: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Dec 2017 04:57:44 -0000 On Dec 8, 2017 8:07 PM, "Eitan Adler" wrote: On 8 December 2017 at 12:11, Rodney W. Grimes wrote: > Ping, I have not seen this reverted and recommitted with a reasonable > explination as to why this change is actually desired. Sorry, work has been busy and as the crux was reverted it didn't feel as urgent[0]. The answer is that shell scripts in scripts don't need to be chmod +x to work. In fact most are not. Of the tests I found from a simple search: 65 are chmod +x 84 are chmod -x The entirety of the changed config is: "chmod": { "type": "chmod", + "exclude": "(/tests/)" }, which simply disables this test during 'arc diff'. +1 to this change, but I think it would've been worthy of its own commit. I don't recall off-hand if it's ATF-specific or not- in that case, at least, the scripts are merely being processed into atf-sh script for when it ends up in /usr/tests. It's probably worth double checking the non-ATF case to make sure -x won't break their expected execution, though. - Kyle Evans