From nobody Mon Feb 20 18:33:10 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PL9zc3g2Dz3rTsH for ; Mon, 20 Feb 2023 18:33:48 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PL9zc2vKfz4bwM for ; Mon, 20 Feb 2023 18:33:48 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676918028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NaxbhgB6Dc+k3R4CZmssb8jhX4grMhuEr4UTVYn2g2k=; b=IZdKVz8dDqBIInwP5ObAy+5cvl0pM5kanpGnoVP2tOuNfssaAOjHcfg+ky/8qwL5Wi48ly 9jCKSSd/fW7092VgDZrdYPQIM5BDvhPLrcltXpaZOp88D7YiMSbPStd+4Q1W1O5g+KASFQ gQuUao0ryLPJKFzJlDrip3JNlMTezCyOzzMGOCliDxwjADrTEXOatSgTbyoho6foQSl71k MWrM4bRqXUHUOl8O/jC4Q5HyjYjxx+Vf1zVj65AZKe0lJdXwW7uixjLHEhPCcg9Jcje5bF GGUbW8on4cSzHmKqCL1OMfZ2MpVcHUfhtZOa8j0UzMgOCaeVOJf4Fp+bb+ZWYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676918028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NaxbhgB6Dc+k3R4CZmssb8jhX4grMhuEr4UTVYn2g2k=; b=rQ1+h2vhsDbtbZmh7hgc4Z2JepPH3n8EVnbduf/rGHqu7hzNINv5xLYB0S+sgwYlszNrIE 208KMdw04DOcyCHwKbjmk0ogQd8YCiJIVXnzwV266rglqFSmmfVUo4OfKhgukuKnH1pgep oo1wFQUOSmcsd1lNx1Y4Gt9NWb4Iba2KPB7YyTZ1evLUr+Mi/jDCRQSnse2ST50MSxucDB PLVLr6SKLEm2P9N1E73/0groD5F3WmJOrKrFxRfjsUNXGt9R4yFNjlrSyNt5+muzR+XYvk blhQLA33BIQ2YIYqQk765doGmf/fov1NSQSYRVxkEfsKRBwxJfp2c5bJKZX3wA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676918028; a=rsa-sha256; cv=none; b=diHVpvAFgce7DkkaKMniojQR12ILf3XopYiiqQsuH311z3wH2Gf1BZcxtuf3SqWLsfyUvU PbzZPFSn58s1TTowhgzgbtIRuF2jQnJkeL3rTdlqwHhBWbR/74RGJcidETYdxsa4HbMqpw c83DoutnUvchkLgyWhDEXzkgRsKsz2v5Q1KAMzqYvTwvTzapXwIU93l9ss1B9wOLtOJQka S4v6kVyfaR5GwVLMI7CLFupRcBSIuozsydScl44phGUDQc5IYvgxy5ua0hf6JFFwsbYAii sae66jNomZUKtU5Apz9+XHFU3bZgB7fqG1mt1T8eROtZzAPqeurfCYHgbcuSIw== Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PL9zc1mc2z1B9b for ; Mon, 20 Feb 2023 18:33:48 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f52.google.com with SMTP id g1so7890400edz.7 for ; Mon, 20 Feb 2023 10:33:48 -0800 (PST) X-Gm-Message-State: AO0yUKVxWKvm1KVil9hpU+Slf4hbbG2k8jUGcFqGjI7+GynDPfvW0vYU rhN8CQG9DAN+uv05ofpRAPHn1n9b6VQ/23ndGINzAA== X-Google-Smtp-Source: AK7set/eXdxvSX/l8kLu4ygxRoSv/JCGyMxH8J8GHLBtAHHlNFSvpaJ+g5tGDljIe0ajdIru5BwjKa/NcCLnbYV2FXA= X-Received: by 2002:a50:baa4:0:b0:4ac:20b:96b0 with SMTP id x33-20020a50baa4000000b004ac020b96b0mr643634ede.3.1676918027085; Mon, 20 Feb 2023 10:33:47 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202301301306.30UD63Np053142@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Tue, 21 Feb 2023 02:33:10 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 23e0e7b1c30f - main - multimedia/mediainfo: Use all-in-one tarball To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000527dfb05f525e77b" X-ThisMailContainsUnwantedMimeParts: N --000000000000527dfb05f525e77b Content-Type: text/plain; charset="UTF-8" On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg wrote: > Hi, > > Porters Handbook (indirectly) recommends you to sanitize sources. > > https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements Do you mean the removal of USES=dos2unix? This port does not install any text file but only 1 binary executable. Therefore USES=dos2unix is unnecessary. I also checked that the generated bin/mediainfo are identical. > Best regards, > Daniel > > On 2023-01-30 14:06, Po-Chuan Hsieh wrote: > > The branch main has been updated by sunpoet: > > > > URL: > > > https://cgit.FreeBSD.org/ports/commit/?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291 > > > > commit 23e0e7b1c30fc6f86957a7428e51a5ea9c594291 > > Author: Po-Chuan Hsieh > > AuthorDate: 2023-01-30 12:27:47 +0000 > > Commit: Po-Chuan Hsieh > > CommitDate: 2023-01-30 12:59:06 +0000 > > > > multimedia/mediainfo: Use all-in-one tarball > > > > - Update WWW > > - Remove unnecessary USES=dos2unix > > --- > > multimedia/mediainfo/Makefile | 20 +++++++++----------- > > multimedia/mediainfo/distinfo | 6 +++--- > > 2 files changed, 12 insertions(+), 14 deletions(-) > > > > diff --git a/multimedia/mediainfo/Makefile > > b/multimedia/mediainfo/Makefile > > index 5766752579b5..9b7c3737d89f 100644 > > --- a/multimedia/mediainfo/Makefile > > +++ b/multimedia/mediainfo/Makefile > > @@ -1,13 +1,14 @@ > > PORTNAME= mediainfo > > -DISTVERSION= 22.12 > > +PORTVERSION= 22.12 > > CATEGORIES= multimedia > > -MASTER_SITES= > https://mediaarea.net/download/source/${PORTNAME}/${DISTVERSION}/ > > \ > > +MASTER_SITES= > https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/ > > \ > > LOCAL/sunpoet > > -DISTNAME= ${PORTNAME}_${DISTVERSION} > > +DISTNAME= MediaInfo_CLI_${PORTVERSION}_GNU_FromSource > > > > MAINTAINER= sunpoet@FreeBSD.org > > COMMENT= Provides technical and tag information for video and audio > > files > > -WWW= https://mediaarea.net/en/MediaInfo > > +WWW= https://mediaarea.net/en/MediaInfo \ > > + https://github.com/MediaArea/MediaInfo > > > > LICENSE= BSD2CLAUSE > > LICENSE_FILE= ${WRKSRC}/../../../License.html > > @@ -15,17 +16,14 @@ LICENSE_FILE= ${WRKSRC}/../../../License.html > > LIB_DEPENDS= libmediainfo.so:multimedia/libmediainfo \ > > libzen.so:multimedia/libzen > > > > -USES= autoreconf compiler:c++11-lang cpe dos2unix > libtool pathfix \ > > - pkgconfig tar:xz > > +USES= compiler:c++11-lang cpe libtool pathfix pkgconfig > tar:xz > > > > GNU_CONFIGURE= yes > > -USE_CXXSTD= c++11 > > USE_LDCONFIG= yes > > -CPE_VENDOR= mediaarea > > -DOS2UNIX_GLOB= *.c *.cpp *.h > > -DOS2UNIX_WRKSRC= ${WRKDIR} > > > > PLIST_FILES= bin/mediainfo > > -WRKSRC= ${WRKDIR}/MediaInfo/Project/GNU/CLI > > +WRKSRC= > ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI > > + > > +CPE_VENDOR= mediaarea > > > > .include > > diff --git a/multimedia/mediainfo/distinfo > > b/multimedia/mediainfo/distinfo > > index 0d9caebdc92b..995778948454 100644 > > --- a/multimedia/mediainfo/distinfo > > +++ b/multimedia/mediainfo/distinfo > > @@ -1,3 +1,3 @@ > > -TIMESTAMP = 1672606752 > > -SHA256 (mediainfo_22.12.tar.xz) = > > 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc > > -SIZE (mediainfo_22.12.tar.xz) = 2026408 > > +TIMESTAMP = 1674589524 > > +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = > > e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef1106947 > > +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = 3352944 > --000000000000527dfb05f525e77b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Feb 11, 2023 at 3:43 PM Daniel En= gberg <diizzy@fr= eebsd.org> wrote:
Hi,

Porters Handbook (indirectly) recommends you to sanitize sources.
https://do= cs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replace= ments

Do you mean the removal of USES= =3Ddos2unix?
This port does not install any text file but only 1 = binary executable.
Therefore USES=3Ddos2unix is unnecessary.

I also checked that the generated=C2=A0bin/mediainfo a= re identical.


Best regards,
Daniel

On 2023-01-30 14:06, Po-Chuan Hsieh wrote:
> The branch main has been updated by sunpoet:
>
> URL:
> https://cgi= t.FreeBSD.org/ports/commit/?id=3D23e0e7b1c30fc6f86957a7428e51a5ea9c594291
>
> commit 23e0e7b1c30fc6f86957a7428e51a5ea9c594291
> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2023-01-30 12:27:47 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2023-01-30 12:59:06 +0000
>
>=C2=A0 =C2=A0 =C2=A0multimedia/mediainfo: Use all-in-one tarball
>
>=C2=A0 =C2=A0 =C2=A0- Update WWW
>=C2=A0 =C2=A0 =C2=A0- Remove unnecessary USES=3Ddos2unix
> ---
>=C2=A0 multimedia/mediainfo/Makefile | 20 +++++++++-----------
>=C2=A0 multimedia/mediainfo/distinfo |=C2=A0 6 +++---
>=C2=A0 2 files changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/multimedia/mediainfo/Makefile
> b/multimedia/mediainfo/Makefile
> index 5766752579b5..9b7c3737d89f 100644
> --- a/multimedia/mediainfo/Makefile
> +++ b/multimedia/mediainfo/Makefile
> @@ -1,13 +1,14 @@
>=C2=A0 PORTNAME=3D=C2=A0 =C2=A0 mediainfo
> -DISTVERSION=3D 22.12
> +PORTVERSION=3D 22.12
>=C2=A0 CATEGORIES=3D=C2=A0 multimedia
> -MASTER_SITES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://mediaarea.net/download/source/${PORTNAME}/${D= ISTVERSION}/
> \
> +MASTER_SITES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://mediaarea.net/download/binary/mediainfo/${PORTVERSI= ON}/
> \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0LOCAL/sunpoet > -DISTNAME=3D=C2=A0 =C2=A0 ${PORTNAME}_${DISTVERSION}
> +DISTNAME=3D=C2=A0 =C2=A0 MediaInfo_CLI_${PORTVERSION}_GNU_FromSource<= br> >
>=C2=A0 MAINTAINER=3D=C2=A0 sunpoet@FreeBSD.org
>=C2=A0 COMMENT=3D=C2=A0 =C2=A0 =C2=A0Provides technical and tag informa= tion for video and audio
> files
> -WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://mediaarea.ne= t/en/MediaInfo
> +WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://mediaarea.ne= t/en/MediaInfo \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://= github.com/MediaArea/MediaInfo
>
>=C2=A0 LICENSE=3D=C2=A0 =C2=A0 =C2=A0BSD2CLAUSE
>=C2=A0 LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WRKSRC}/../../../Li= cense.html
> @@ -15,17 +16,14 @@ LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0${WRKSRC}/../..= /../License.html
>=C2=A0 LIB_DEPENDS=3D libmediainfo.so:multimedia/libmediainfo \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libzen.so:multim= edia/libzen
>
> -USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 autore= conf compiler:c++11-lang cpe dos2unix libtool pathfix \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pkgconfig tar:xz
> +USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compil= er:c++11-lang cpe libtool pathfix pkgconfig tar:xz
>
>=C2=A0 GNU_CONFIGURE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes
> -USE_CXXSTD=3D=C2=A0 c++11
>=C2=A0 USE_LDCONFIG=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 yes
> -CPE_VENDOR=3D=C2=A0 mediaarea
> -DOS2UNIX_GLOB=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0*.c *.cpp *.h
> -DOS2UNIX_WRKSRC=3D=C2=A0 =C2=A0 =C2=A0${WRKDIR}
>
>=C2=A0 PLIST_FILES=3D bin/mediainfo
> -WRKSRC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WRKDIR}/M= ediaInfo/Project/GNU/CLI
> +WRKSRC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WRKDIR}/M= ediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI
> +
> +CPE_VENDOR=3D=C2=A0 mediaarea
>
>=C2=A0 .include <bsd.port.mk>
> diff --git a/multimedia/mediainfo/distinfo
> b/multimedia/mediainfo/distinfo
> index 0d9caebdc92b..995778948454 100644
> --- a/multimedia/mediainfo/distinfo
> +++ b/multimedia/mediainfo/distinfo
> @@ -1,3 +1,3 @@
> -TIMESTAMP =3D 1672606752
> -SHA256 (mediainfo_22.12.tar.xz) =3D
> 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc
> -SIZE (mediainfo_22.12.tar.xz) =3D 2026408
> +TIMESTAMP =3D 1674589524
> +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) =3D
> e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef1106947
> +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) =3D 3352944
--000000000000527dfb05f525e77b--