From owner-freebsd-net@freebsd.org Tue Mar 15 06:18:48 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDE0BAD10AD for ; Tue, 15 Mar 2016 06:18:48 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 67D1C15F6 for ; Tue, 15 Mar 2016 06:18:48 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-wm0-x22b.google.com with SMTP id p65so129388490wmp.1 for ; Mon, 14 Mar 2016 23:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=MTIOCz+BL7HgVW4Mk9D9J3bfXZcA2p3guYwg49/hjI4=; b=ai8CawYNWS8cE3Juj7E5cXWi5gGdHxZHiXDxEHMGkRfCjMhP+mac5szVTpUtRurgQ7 mO7mtR4DI+M1uqqvudY1jLFKh08CTGAprz48gLsIs+r9fhXnsrFcPRccJ7hRLF0cySQV 0PoPGLDtr+Vz4x9rC8fNeLu0N982NCO5VK3gZPlwu6z6CfDGjH9BHZPt79j8MzFwX8Io prIuIM6NG3mhyFoJXOIY4cL4+wyq+i2pHpg0XW4UMFvEKQDXHD0GIpVwG7N/LVzTcUlH JahJTXMJBfsPSjrc0wasi2/SghBjKljuhTF1ww7dHCXelauKF9wmduHX2afv64hZ/wM6 43bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=MTIOCz+BL7HgVW4Mk9D9J3bfXZcA2p3guYwg49/hjI4=; b=Tv3sABTBJvib8iiWPIkdSBTcfQNK0heu6XU4Z85wpdqlT0FsCacFayYSsi0Um6Q4P0 RemySwK75HKkZiSEYJ8tGT66cQqWHhdFbeEMzSN57zRfkrXDJ1r6+tBR0d3RDfbjZ8Ef 8gbBXD8Sj42HE2Df5jHeM6Qd+wfmiCB77qV887xKgLRsoIanTAQ6wnpp9AcRAeaQoFZK 8+/aK8QtlaueH0dbP9bxMqiv/Eyr+lEC0/xXzXTJQ4je3x81IgD65I9t4Nnm0h9yYIas mANx37dXzkEoqOCGkn4ZV1MbezUlAlCYR9EoDmBDD+4p9RrQB2SyCq1/GKlhrE896PdC o7HQ== X-Gm-Message-State: AD7BkJJ7K6Fu89nvpZ7Yjh/qfBO9ZoU1twenRTF3j3i6pIEhPLSRSdz3FXGi3pyh7OBl89yQnr7NsB5sNwbtNA== MIME-Version: 1.0 X-Received: by 10.28.214.11 with SMTP id n11mr20484043wmg.31.1458022726822; Mon, 14 Mar 2016 23:18:46 -0700 (PDT) Received: by 10.194.23.104 with HTTP; Mon, 14 Mar 2016 23:18:46 -0700 (PDT) In-Reply-To: <20160315015542.GA61626@thinkpad.swarthmore.edu> References: <20160315015542.GA61626@thinkpad.swarthmore.edu> Date: Tue, 15 Mar 2016 07:18:46 +0100 Message-ID: Subject: Re: Int overflow in dhclient(1) From: Ben Woods To: Michael McConville Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2016 06:18:48 -0000 On Tuesday, 15 March 2016, Michael McConville wrote: > I sent this a few weeks ago, but it never got applied: > > https://marc.info/?l=freebsd-net&m=145392057613453&w=2 > > Here's my explanation for the same fix in OpenBSD: > > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 > > Thanks for your time, > Michael > > > Index: sbin/dhclient/dhclient.c > =================================================================== > --- sbin/dhclient/dhclient.c (revision 296886) > +++ sbin/dhclient/dhclient.c (working copy) > @@ -138,7 +138,7 @@ > findproto(char *cp, int n) > { > struct sockaddr *sa; > - int i; > + unsigned int i; > > if (n == 0) > return -1; > Hi Michael, Seems like a bug report should be raised so this one doesn't get lost/ignored. Would you be able to raise one here please? https://bugs.freebsd.org/ Regards, Ben -- -- From: Benjamin Woods woodsb02@gmail.com