Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Jun 2016 19:12:08 +0000 (UTC)
From:      Rene Ladan <rene@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org
Subject:   svn commit: r416562 - in branches/2016Q2/www/chromium: . files
Message-ID:  <201606081912.u58JC8J8072448@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rene
Date: Wed Jun  8 19:12:08 2016
New Revision: 416562
URL: https://svnweb.freebsd.org/changeset/ports/416562

Log:
  MFH: r416561
  
  www/chromium: restore WebRTC audio via ALSA which got lost in last commit.
  
  PR:		206480
  Submitted by:	betso.net@gmail.com
  
  Approved by:	ports-secteam (feld)

Added:
  branches/2016Q2/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc
     - copied unchanged from r416561, head/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc
Modified:
  branches/2016Q2/www/chromium/Makefile
Directory Properties:
  branches/2016Q2/   (props changed)

Modified: branches/2016Q2/www/chromium/Makefile
==============================================================================
--- branches/2016Q2/www/chromium/Makefile	Wed Jun  8 19:06:05 2016	(r416561)
+++ branches/2016Q2/www/chromium/Makefile	Wed Jun  8 19:12:08 2016	(r416562)
@@ -3,6 +3,7 @@
 
 PORTNAME=	chromium
 PORTVERSION=	51.0.2704.84
+PORTREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	http://commondatastorage.googleapis.com/chromium-browser-official/
 DISTFILES=	${DISTNAME}${EXTRACT_SUFX} # default, but needed to get distinfo correct if TEST is on
@@ -54,6 +55,7 @@ LIB_DEPENDS=	libasound.so:audio/alsa-lib
 		libxml2.so:textproc/libxml2
 
 RUN_DEPENDS=	${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:audio/alsa-plugins \
+		alsa-lib>=1.1.1_1:audio/alsa-lib \
 		droid-fonts-ttf>0:x11-fonts/droid-fonts-ttf \
 		xdg-open:devel/xdg-utils
 

Copied: branches/2016Q2/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc (from r416561, head/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ branches/2016Q2/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc	Wed Jun  8 19:12:08 2016	(r416562, copy of r416561, head/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc)
@@ -0,0 +1,54 @@
+--- media/audio/alsa/audio_manager_alsa.cc.orig	2016-04-07 19:01:10 UTC
++++ media/audio/alsa/audio_manager_alsa.cc
+@@ -128,7 +128,9 @@ void AudioManagerAlsa::GetAlsaAudioDevic
+   int card = -1;
+ 
+   // Loop through the sound cards to get ALSA device hints.
++#ifdef OS_LINUX
+   while (!wrapper_->CardNext(&card) && card >= 0) {
++#endif
+     void** hints = NULL;
+     int error = wrapper_->DeviceNameHint(card, kPcmInterfaceName, &hints);
+     if (!error) {
+@@ -140,7 +142,9 @@ void AudioManagerAlsa::GetAlsaAudioDevic
+       DLOG(WARNING) << "GetAlsaAudioDevices: unable to get device hints: "
+                     << wrapper_->StrError(error);
+     }
++#ifdef OS_LINUX
+   }
++#endif
+ }
+ 
+ void AudioManagerAlsa::GetAlsaDevicesInfo(
+@@ -226,7 +230,11 @@ bool AudioManagerAlsa::IsAlsaDeviceAvail
+     // goes through software conversion if needed (e.g. incompatible
+     // sample rate).
+     // TODO(joi): Should we prefer "hw" instead?
++#ifdef OS_LINUX
+     static const char kDeviceTypeDesired[] = "plughw";
++#else
++    static const char kDeviceTypeDesired[] = "plug";
++#endif
+     return strncmp(kDeviceTypeDesired,
+                    device_name,
+                    arraysize(kDeviceTypeDesired) - 1) == 0;
+@@ -250,7 +258,9 @@ bool AudioManagerAlsa::HasAnyAlsaAudioDe
+   // Loop through the sound cards.
+   // Don't use snd_device_name_hint(-1,..) since there is a access violation
+   // inside this ALSA API with libasound.so.2.0.0.
++#ifdef OS_LINUX
+   while (!wrapper_->CardNext(&card) && (card >= 0) && !has_device) {
++#endif
+     int error = wrapper_->DeviceNameHint(card, kPcmInterfaceName, &hints);
+     if (!error) {
+       for (void** hint_iter = hints; *hint_iter != NULL; hint_iter++) {
+@@ -274,7 +284,9 @@ bool AudioManagerAlsa::HasAnyAlsaAudioDe
+       DLOG(WARNING) << "HasAnyAudioDevice: unable to get device hints: "
+                     << wrapper_->StrError(error);
+     }
++#ifdef OS_LINUX
+   }
++#endif
+ 
+   return has_device;
+ }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201606081912.u58JC8J8072448>