From nobody Fri Nov 28 01:00:50 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dHZjg2Hl7z6JXJh for ; Fri, 28 Nov 2025 01:00:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dHZjg1jCDz480D for ; Fri, 28 Nov 2025 01:00:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764291655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v+JW15XnIhjy3K1C8MrixecrEZCCrQjDl44Y5S7rqOo=; b=DtKAtTmIMAv9cAZoajjAKeHdt6+2C6L2sTwIQwbtOCOjBJE7demgkyDikH6XUpGGA2rQOp lz/s2hDgGr4wKwnsrM2wygyryVodOvoIjIznbcwyjb9k6p0+5p7WBFxD1FoSBeSOgxpgsx XC76T/JFB1ekPJEwzWEROR5HfX5b6vbjAOiLUKGVGafTzWa5+lpqOjQEGdSlWdqdf0wG2A lYjsSgbL19F2jqxQT578s5ekcEM+VbHQlDzBsxr9uct/a6YntpeFC8w1aa6ZEvd1874y92 BlpfZKsT2BEdNVSxBDmCeRUpg4S3NzN04j2exSC2zPAaOk2Dfr8Rqh2fc7HiRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764291655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v+JW15XnIhjy3K1C8MrixecrEZCCrQjDl44Y5S7rqOo=; b=CouSsow/qxI8b14EjtnScP8Y4lHmdWNZN/f2IcFOew6uVwaDx8eaoFYeowr5hSNF7/7uXt tNWDvVJ9+hFHfsAUGk4g1eQKagSeEPQTNiEB6fwdJYHbxMb9Mn1gwnI2aWbSsm9Qd0fFLA bKm0ermQ1PlG3KI/NgQcFbiLujfWPaQoV7+JcCXnvhWGEmkADppppAgMplhDR/muFKoYmn rDqmROVESt31lDCC43/Xnm/IHcVI/1bCpFcp0mHddghEUFuEs6R4w5VQ7Ahi/uGTkpcWrv FH9baeaCt5z250KKN/wpQ+oC407cLeHVpK/YXvOnjjUaBR4k393Dg6IKfjxyKA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764291655; a=rsa-sha256; cv=none; b=q+vrPJrZdZY+Zc5vl/zxkUpFHIY5SEC5ffw3x6wWyJh+ldj+YrwraRyKCP+cy1W8qS7an+ UauN4SKRkFv+wJtIUv0eIz67MsRK4NWrXTWT2ePUm0M+f55QpkQTy2gGmIEAXjxF2FRPBV Ado3QeHYDr0eW4e32cgpOHyN9JUKz3bLdT9jBcQ7UbtxjPc1dzKWcwKRaEO2l+/ODGpdTn NqEYMxMaFZctIIPV+5J07vth6uVN2+hLoFR4H8+uSHAaI6zNxaXQiv5i4xHntwIVPQXM97 hcbILS5x8+gGSDnzrfH+bNCuWrB0x0ViLbsCWfmQsWs0t5dwwMeihieJL5MF5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dHZjg15Smzgt8 for ; Fri, 28 Nov 2025 01:00:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 278f4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 28 Nov 2025 01:00:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Joseph Mingrone Subject: git: 6049f1bc2106 - main - git-arc: Fix failure to call arc() function List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6049f1bc210653b126974961b29d6eb71a6c6709 Auto-Submitted: auto-generated Date: Fri, 28 Nov 2025 01:00:50 +0000 Message-Id: <6928f442.278f4.18def5e9@gitrepo.freebsd.org> The branch main has been updated by jrm: URL: https://cgit.FreeBSD.org/src/commit/?id=6049f1bc210653b126974961b29d6eb71a6c6709 commit 6049f1bc210653b126974961b29d6eb71a6c6709 Author: Joseph Mingrone AuthorDate: 2025-11-27 22:46:43 +0000 Commit: Joseph Mingrone CommitDate: 2025-11-28 00:53:56 +0000 git-arc: Fix failure to call arc() function As of b3e53f9fff11, git-arc attempted to call the internal shell function, arc(), using env(1). However, because env(1) does not call shell functions, it actually attempted to run the arc utility. This led to errors: % git arc create -r xxx HEAD env: arc: No such file or directory git-arc: could not create Phabricator diff This change removes the unnecessary use of env(1), so the arc() function is correctly called. Reviewed by: markj Fixes: b3e53f9fff11 ("git-arc: Don't require devel/arcanist") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53972 --- tools/tools/git/git-arc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tools/git/git-arc.sh b/tools/tools/git/git-arc.sh index eef01b75663e..8507d96fda63 100755 --- a/tools/tools/git/git-arc.sh +++ b/tools/tools/git/git-arc.sh @@ -315,7 +315,7 @@ create_one_review() printf "\nSubscribers:\n" >> "$msg" printf "%s\n" "${subscribers}" >> "$msg" - yes | env EDITOR=true \ + yes | EDITOR=true \ arc diff --message-file "$msg" --never-apply-patches --create \ --allow-untracked $BROWSE --head "$commit" "${commit}~" [ $? -eq 0 ] || err "could not create Phabricator diff"