From owner-svn-src-all@FreeBSD.ORG Sat Jun 12 14:49:17 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B5FE1065674; Sat, 12 Jun 2010 14:49:17 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109]) by mx1.freebsd.org (Postfix) with ESMTP id 2A4E28FC1E; Sat, 12 Jun 2010 14:49:16 +0000 (UTC) Received: from localhost (unknown [213.17.239.109]) by smtp.semihalf.com (Postfix) with ESMTP id 661A3C42DD; Sat, 12 Jun 2010 16:54:30 +0200 (CEST) X-Virus-Scanned: by amavisd-new at semihalf.com Received: from smtp.semihalf.com ([213.17.239.109]) by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new, port 10024) with ESMTP id 42-67p7X4T7D; Sat, 12 Jun 2010 16:54:29 +0200 (CEST) Received: from [192.168.133.14] (nat3-133.ghnet.pl [91.150.222.133]) by smtp.semihalf.com (Postfix) with ESMTPSA id ACACAC42DB; Sat, 12 Jun 2010 16:54:29 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rafal Jaworowski In-Reply-To: <20100610.092502.72112000528403516.imp@bsdimp.com> Date: Sat, 12 Jun 2010 16:49:14 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201006091957.o59JvKbu025122@svn.freebsd.org> <20100610.092502.72112000528403516.imp@bsdimp.com> To: M. Warner Losh X-Mailer: Apple Mail (2.1078) Cc: svn-src-head@freebsd.org, rdivacky@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r208964 - in head: . etc/mtree lib share/mk usr.bin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2010 14:49:17 -0000 On 2010-06-10, at 17:25, M. Warner Losh wrote: > In message: <201006091957.o59JvKbu025122@svn.freebsd.org> > Roman Divacky writes: > : Modified: head/share/mk/bsd.own.mk > : = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > : --- head/share/mk/bsd.own.mk Wed Jun 9 19:32:20 2010 = (r208963) > : +++ head/share/mk/bsd.own.mk Wed Jun 9 19:57:20 2010 = (r208964) > : @@ -288,6 +288,18 @@ _no_fdt=3D FDT > : .endif > : =20 > : # > : +# Default behaviour of MK_CLANG depends on the architecture. > : +# > : +.if ${MACHINE_ARCH} =3D=3D "amd64" || ${MACHINE_ARCH} =3D=3D "i386" = || \ > : + ${MACHINE_ARCH} =3D=3D "powerpc" > : +_clang_yes=3DCLANG > : +_clang_no=3D > : +.else > : +_clang_yes=3D > : +_clang_no=3DCLANG > : +.endif >=20 > We really should *NOT* be encoding architecture stuff like this into > bsd.own.mk. Sometimes the right thing here is MACHINE_ARCH, and for > the moment, since clang is not a bootstrap tool, this is correct. > However, once clang is a bootstrap tool, this will be incorrect > because during the bootstrapping for cross building TARGET_ARCH is > what should be tested. We have the same problem with the FTD stuff > that was recently committed. raj@ and I have been talking about the > best ways to fix it. I think I'm going to drop setting WITH_FDT by default for selected = arches until the tdbemd arrives, and for this little (I hope :-) while = it will just be required for FDT-enabled platforms to specify WITH_FDT = explicitly. Rafal