From owner-svn-src-head@FreeBSD.ORG  Tue Sep 27 18:23:59 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 00E9D1065673;
	Tue, 27 Sep 2011 18:23:59 +0000 (UTC) (envelope-from des@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id E45318FC0C;
	Tue, 27 Sep 2011 18:23:58 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p8RINwuV035627;
	Tue, 27 Sep 2011 18:23:58 GMT (envelope-from des@svn.freebsd.org)
Received: (from des@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id p8RINwQ3035625;
	Tue, 27 Sep 2011 18:23:58 GMT (envelope-from des@svn.freebsd.org)
Message-Id: <201109271823.p8RINwQ3035625@svn.freebsd.org>
From: Dag-Erling Smorgrav <des@FreeBSD.org>
Date: Tue, 27 Sep 2011 18:23:58 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r225810 - head/lib/libfetch
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2011 18:23:59 -0000

Author: des
Date: Tue Sep 27 18:23:58 2011
New Revision: 225810
URL: http://svn.freebsd.org/changeset/base/225810

Log:
  Long overdue: make passive mode the default for ftp.

Modified:
  head/lib/libfetch/ftp.c

Modified: head/lib/libfetch/ftp.c
==============================================================================
--- head/lib/libfetch/ftp.c	Tue Sep 27 18:14:04 2011	(r225809)
+++ head/lib/libfetch/ftp.c	Tue Sep 27 18:23:58 2011	(r225810)
@@ -638,8 +638,8 @@ ftp_transfer(conn_t *conn, const char *o
 
 	/* passive mode */
 	if (!pasv)
-		pasv = ((s = getenv("FTP_PASSIVE_MODE")) != NULL &&
-		    strncasecmp(s, "no", 2) != 0);
+		pasv = ((s = getenv("FTP_PASSIVE_MODE")) == NULL ||
+		    strncasecmp(s, "no", 2) == 0);
 
 	/* isolate filename */
 	filename = ftp_filename(file, &filenamelen, &type);