From nobody Mon Dec 2 22:25:54 2024 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y2JK957KCz5gXtv for ; Mon, 02 Dec 2024 22:26:05 +0000 (UTC) (envelope-from mp@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y2JK94Z3Gz49Qg for ; Mon, 2 Dec 2024 22:26:05 +0000 (UTC) (envelope-from mp@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733178365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=msCWl6Fx7sjddkUUcLQfxmUgPbn3KmNoI64zXfpBB1Y=; b=uPoaEUDrpiXF00SpXeY+cuXohZXpKPjSdM3oXMLMKA0FCql3DmVpMLaOYqk4LtTDuHyz4t Bvpg3MKpICbJG8tCiIO8VKpPLvxCccSaeAN9W8Mda7P9hPviO3/QbUnWBPCeWmP2I/Ghjv FS/Uc+C6KTspNVSXxrqK4K/mOgB/F7qcwTyGLEpCv1sAAtablGCezVeP0pz2me3U+cn2Qo 608g6tzhsJD+f2akbXFTsZ0hgzfObLJbYCr3GcAQNOdnxZcbyDEAkOK0apxvFJTrghlm8n XVvaAKytjQ3V8Qjcu1+N961YOfIwFRBxh4xdBV3Tfvm4FXMGQ9+khFVOKRabyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733178365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=msCWl6Fx7sjddkUUcLQfxmUgPbn3KmNoI64zXfpBB1Y=; b=hvxyxZbrKDV9/aqBbPQ5PrTfUH/D/8byzV3JYtqYEXnB3f2ujLg30QLZCe7Xyo+6SuNiqd 6ZE7d/kPR5DyfV5YzPXcif7PV1534nZmoG8qwIyMSy7pIVpWvUdi8KkxFu8KWM4eOBoEle VpLuETUVGbMO+c7+L0selREVWJoXWrfgVg0re0adGMDuj0Cxjjp55K3ViQsZ2MmoDfAzQf 3Y9f0+3rPYovZbg1z7YhIw12DG2gr3GanOdSp6ZmpsSF9FhjQCyFrt14oVUILGYQxzR+eW 2ht5ZJZiKyStSBV7GEHB3Uq+x9IC1+Re/VRazKOxyXyPn2R0J3pwjCoBZ1t7Xw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733178365; a=rsa-sha256; cv=none; b=nwFalUifrtAOl32CphKlDb8wmjAXoLCUTZb4izZBHg9yNNEsvHPoRii7UkawbgxvATjByD zr9u2CQjxhLG6xULSc+VDQYUfLZRPz+bZfRSg5FQVrUuKm6BlbTAWlOg57CCmcktWQKSLY MZD/xTNumRCr2JUQnXZnPaqzKSk8FRJffDnDQoFXnSSb9EAVvU/S6EiOkhEOC4F2BfvudO kEIywlXVpDjgY5QWgJQeC+HYc86loMbh6YU5IsiCQSliWQ+F33TudP84I5kWB+1uJe/2O0 EcHG4E7YqWbzH9rb9CHh4LsOdJ9ZVOrlaN8hsQtY7+rsiy3sfyXjFZ6WFbujhQ== Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: mp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Y2JK94BdCz1FTj for ; Mon, 2 Dec 2024 22:26:05 +0000 (UTC) (envelope-from mp@freebsd.org) Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6d882699271so26181776d6.1 for ; Mon, 02 Dec 2024 14:26:05 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWmo2eBDZNTOx5odN/8R6kSweqXyzsIJFL4kzDvR9nyUsz5Zd1bEKEv/XJYGEkJCGjvSGFsdjXg7W4GwUJV8T6NEJSZD9pI@freebsd.org X-Gm-Message-State: AOJu0Yze+qv3Mw4ttOGfOBfzSU/SLaoZrHkyM7PnwyenEV4ltvB+qtwe E3Gren/mhABlAUslrT34cEGLO1aSNyuP8ESQTdUENVTVTHd0L18driUTSJGjkf9Xq4lxbn9Zbfr WdHloBY8lXEGPAWtIUC0nUemK4WmKzx8igvUcng== X-Google-Smtp-Source: AGHT+IGPY8qLyxa9zPlP1tZrjypT3/dETYsECUpW0sH9JZaCjE3cSA9Np7Lt2MZy7Mj1CSADEz0HJjPLJ4tAeCH0zmA= X-Received: by 2002:a05:6214:21ac:b0:6cb:ef8d:b10 with SMTP id 6a1803df08f44-6d8b7405fe2mr5947726d6.39.1733178364992; Mon, 02 Dec 2024 14:26:04 -0800 (PST) List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-virtualization@freebsd.org Sender: owner-freebsd-virtualization@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Mark Peek Date: Mon, 2 Dec 2024 14:25:54 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Failed to emulate instruction sequence [ 41f646040874064c017d88eb144c89 ] at 0xbea5fcf9 To: Mario Marietto Cc: Mark Peek , =?UTF-8?Q?Corvin_K=C3=B6hne?= , FreeBSD virtualization Content-Type: multipart/alternative; boundary="000000000000c742ba0628510804" --000000000000c742ba0628510804 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 2, 2024 at 1:35=E2=80=AFPM Mario Marietto wrote: > Yes,I have also exchanged the bhyve binary. Now I'm trying to apply your > patch and then I will rebuild vmm. > I see that your code is : > > [0xF6] =3D { > /* XXX Group 3 extended opcode - not just TEST */ > .op_byte =3D 0xF6, > .op_type =3D VIE_OP_TYPE_TEST, > .op_flags =3D VIE_OP_F_IMM, > }, > > but it seems wrong. Shouldn't be .op_flags =3D VIE_OP_F_IMM8 ? > Yes, per the discussion in the bug report, that was the change I need to make before submitting it for review. Please make that change in your copy. And per email after this one, yes, that compilation of vmm.ko looks fine. Mark --000000000000c742ba0628510804 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Dec 2, 2024 at 1:35=E2=80=AFPM Ma= rio Marietto <marietto2008@gma= il.com> wrote:
Ye= s,I have also exchanged the bhyve binary. Now I'm trying to apply your = patch and then I will rebuild vmm.
I see that your code is :=

[0xF6] =3D {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* XXX Group 3 extended opcode - not just TEST = */
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .op_byte =3D = 0xF6,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .op_type = =3D VIE_OP_TYPE_TEST,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 .op_flags =3D VIE_OP_F_IMM,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 },
<= div>
but it seems wrong. Shouldn't be .op_flags =3D VIE_O= P_F_IMM8 ?

Yes, per the discuss= ion in the bug report, that was the change I need to make before submitting= it for review. Please make that change in your copy.

<= div>And per email after this one, yes, that compilation of vmm.ko looks fin= e.

Mark
--000000000000c742ba0628510804--