From owner-freebsd-net@FreeBSD.ORG Fri Sep 10 08:14:30 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A87C106566C for ; Fri, 10 Sep 2010 08:14:30 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id B48D58FC13 for ; Fri, 10 Sep 2010 08:14:29 +0000 (UTC) Received: by bwz20 with SMTP id 20so2340285bwz.13 for ; Fri, 10 Sep 2010 01:14:28 -0700 (PDT) Received: by 10.204.15.148 with SMTP id k20mr318394bka.74.1284106468587; Fri, 10 Sep 2010 01:14:28 -0700 (PDT) Received: from jessie.localnet (p5B0E3D6C.dip0.t-ipconnect.de [91.14.61.108]) by mx.google.com with ESMTPS id y2sm1785461bkx.20.2010.09.10.01.14.26 (version=SSLv3 cipher=RC4-MD5); Fri, 10 Sep 2010 01:14:27 -0700 (PDT) From: Bernhard Schmidt To: Christian Brueffer Date: Fri, 10 Sep 2010 10:14:24 +0200 User-Agent: KMail/1.13.2 (Linux/2.6.32-24-generic; KDE/4.4.2; i686; ; ) References: <20100905165308.00000d99@unknown> <201009051911.59912.bschmidt@techwires.net> <20100909192806.GD2338@serenity> In-Reply-To: <20100909192806.GD2338@serenity> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009101014.25068.bschmidt@techwires.net> Cc: Bruce Cran , freebsd-net@freebsd.org Subject: Re: mwl(4) depends on non-existant mwlfw_fw (mwlfw doesn't implement mwlfw_fw) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2010 08:14:30 -0000 On Thursday, September 09, 2010 21:28:06 Christian Brueffer wrote: > On Sun, Sep 05, 2010 at 07:11:59PM +0200, Bernhard Schmidt wrote: > > On Sunday 05 September 2010 18:52:05 Bernhard Schmidt wrote: > > > On Sunday 05 September 2010 17:53:08 Bruce Cran wrote: > > > > Hi, > > > > > > > > I was trying to help someone on IRC with a card that should be > > > > supported by the mwl(4) driver, but it seems it's broken: mwlfw(4) > > > > doesn't implement mwlfw_fw which if_mwl depends on > > > > ("MODULE_DEPEND(mwl, mwlfw_fw, 1, 1, 1);"). > > > > > > This is wrong. It should depend on firmware(9), which also takes care > > > of loading the adequate firmware modules. I committed a fix for the firmware module dependencies. Thanks for pointing this out! > > > > Should it be trying to load mw88W8363fw dynamically instead? > > > > > > Yes, firmware(9) does that. > > > > > > > The same error appears to be in malo(4) too - and neither mwlfw(4) or > > > > malofw(4) are installed during an installkernel despite mwl(4) and > > > > malo(4) being installed. > > > > > > Seems like there is a MFC missing those get installed on HEAD. > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=144494 > > Oops, this fell through the cracks due to the missing MFC reminder > trigger. Fixed! Thanks! -- Bernhard