From owner-svn-src-all@freebsd.org  Wed May 10 15:35:42 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79D68D66792;
 Wed, 10 May 2017 15:35:42 +0000 (UTC)
 (envelope-from tsoome@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BE0177A;
 Wed, 10 May 2017 15:35:42 +0000 (UTC)
 (envelope-from tsoome@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v4AFZfeH009451;
 Wed, 10 May 2017 15:35:41 GMT (envelope-from tsoome@FreeBSD.org)
Received: (from tsoome@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v4AFZfOR009450;
 Wed, 10 May 2017 15:35:41 GMT (envelope-from tsoome@FreeBSD.org)
Message-Id: <201705101535.v4AFZfOR009450@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: tsoome set sender to
 tsoome@FreeBSD.org using -f
From: Toomas Soome <tsoome@FreeBSD.org>
Date: Wed, 10 May 2017 15:35:41 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r318142 - head/lib/libstand
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 May 2017 15:35:42 -0000

Author: tsoome
Date: Wed May 10 15:35:41 2017
New Revision: 318142
URL: https://svnweb.freebsd.org/changeset/base/318142

Log:
  libstand: NULL pointer dereference in rarp
  
  readether argument is missing & operator.
  
  CID:		1374944
  Reported by:	Coverity, cem
  Reviewed by:	cem
  Differential Revision:	https://reviews.freebsd.org/D10663

Modified:
  head/lib/libstand/rarp.c

Modified: head/lib/libstand/rarp.c
==============================================================================
--- head/lib/libstand/rarp.c	Wed May 10 15:27:36 2017	(r318141)
+++ head/lib/libstand/rarp.c	Wed May 10 15:35:41 2017	(r318142)
@@ -155,7 +155,7 @@ rarprecv(struct iodesc *d, void **pkt, v
 		printf("rarprecv: ");
 #endif
 
-	n = readether(d, ptr, (void **)&ap, tleft, &etype);
+	n = readether(d, &ptr, (void **)&ap, tleft, &etype);
 	errno = 0;	/* XXX */
 	if (n == -1 || n < sizeof(struct ether_arp)) {
 #ifdef RARP_DEBUG