Date: Fri, 07 Jul 2023 21:43:55 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Mark Johnston <markj@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Pierre Pronchery <pierre@freebsdfoundation.org> Subject: Re: git: b077aed33b7b - main - Merge OpenSSL 3.0.9 Message-ID: <C6C97845-BD65-414F-9570-7DD9F7F1EDA4@FreeBSD.org> In-Reply-To: <6EF29DA8-B987-4C98-826C-0128C43764C6@freebsd.org> References: <ZKg-3RqIaz9VOPD_@nuc> <6EF29DA8-B987-4C98-826C-0128C43764C6@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7 Jul 2023, at 19:52, Kristof Provost wrote: >> On 7 Jul 2023, at 18:35, Mark Johnston <markj@freebsd.org> wrote: >> >> =EF=BB=BFOn Wed, Jul 05, 2023 at 11:56:42PM +0200, Kristof Provost wro= te: >>>> On 24 Jun 2023, at 1:19, Ed Maste wrote: >>>> The branch main has been updated by emaste: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Db077aed33b7b6aefca7b1= 7ddb250cf521f938613 >>>> >>>> commit b077aed33b7b6aefca7b17ddb250cf521f938613 >>>> Merge: b08ee10c0646 b84c4564effd >>>> Author: Pierre Pronchery <pierre@freebsdfoundation.org> >>>> AuthorDate: 2023-06-23 22:53:35 +0000 >>>> Commit: Ed Maste <emaste@FreeBSD.org> >>>> CommitDate: 2023-06-23 22:53:36 +0000 >>>> >>>> Merge OpenSSL 3.0.9 >>>> >>> >>> It looks like we missed adding a file. >>> Security/opensc doesn=E2=80=99t build any more: >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270076 >>> >>> It fails to find d2i_KeyParams when linking. The opensc code does thi= s: >>> >>> #if OPENSSL_VERSION_NUMBER < 0x30000000L >>> if (!d2i_ECParameters(&ec, &a, (lo= ng)len)) >>> util_fatal("cannot parse >>> EC_PARAMS"); >>> EVP_PKEY_assign_EC_KEY(pkey, ec); >>> #else >>> if (!d2i_KeyParams(EVP_PKEY_EC, &p= key, &a, >>> len)) >>> util_fatal("cannot parse >>> EC_PARAMS"); >>> #endif >>> >>> d2i_KeyParams() appears to be new on openssl 3. It=E2=80=99s defined = in d2i_param.c, >>> which we don=E2=80=99t build. I=E2=80=99ve tested with this patch, an= d that appears to fix >>> things: >> >> Hi Kristof, >> >> Would you mind posting the patch on phabricator? I can take a closer >> look in the next day, and Pierre might be available to look as well. > > Sure, but I might not be able to do that until Sunday afternoon. > https://reviews.freebsd.org/D40914 >>> Based on your analysis I think this should go into the OPENSSL_3_0_9 >> namespace? >> > I have no idea. I=E2=80=99ll try to dig a bit, but we=E2=80=99re pretty= far outside my comfort zone here. > Ah, I see what you meant. That should be fixed in the version in the revi= ew. Best regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C6C97845-BD65-414F-9570-7DD9F7F1EDA4>