From owner-freebsd-ports Sun Sep 20 08:40:27 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA09989 for freebsd-ports-outgoing; Sun, 20 Sep 1998 08:40:27 -0700 (PDT) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA09984 for ; Sun, 20 Sep 1998 08:40:26 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA07148; Sun, 20 Sep 1998 08:40:00 -0700 (PDT) Date: Sun, 20 Sep 1998 08:40:00 -0700 (PDT) Message-Id: <199809201540.IAA07148@freefall.freebsd.org> To: freebsd-ports@FreeBSD.ORG From: Tim Vanderhoek Subject: Re: ports/7995: New Port: OpenLDAP 1.0.1 Reply-To: Tim Vanderhoek Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR ports/7995; it has been noted by GNATS. From: Tim Vanderhoek To: lodea@angmar.mel.cybec.com.au, FreeBSD-gnats-submit@FreeBSD.ORG Cc: Subject: Re: ports/7995: New Port: OpenLDAP 1.0.1 Date: Sun, 20 Sep 1998 11:37:02 -0400 On Sun, Sep 20, 1998 at 09:23:59PM +1000, lodea@angmar.mel.cybec.com.au wrote: > > XUniversity of Michigan LDAP release 3.3 and is distributed under a > XPerl-style "Artistic License". > X > XChanges from U. Mich release 3.3: Yes, but WHAT THE F! IS LDAP!?!!?!? [I'm sorry, the frustration expressed here isn't directed towards you specifically...it's directed generally since this is a ridiculously common mistake]. Please add at least a short line or two telling the user wtf they give a shit about ldap. Ideally, say what ldap is used for and what differentiates OpenLDAP from other ldap implementations. > X - TCP Wrappers support added to slapd, > X - Berkely DB2 compatibility added to slapd, > X - ACL enhancements including Access by Group and POSIX regex(3) > X support, > X - platforms updates, and > X - numerous bug fixes and build changes. Chances are I don't really care about those last two points very much. Are you planning to upgrade pkg/DESCR with each new version of OpenLDAP? What if they ever release a version that doesn't contain "numerous bug fixes and build changes and platform updates" from the last version? Truthfully, I (speaking for the generalized FreeBSD ports user) really don't care very much at all about changes from previous versions when I'm reading pkg/DESCR... The pkg/DESCR should be marginally (marginally) version-independent. FWIW, I'm not a terribly large fan of -item lists either, although there's nothing really wrong with them and you can feel free to use one. > X > XSee the CHANGES file in the distribution for more details. Did you install the CHANGES file in /usr/local/share/doc/openldap/? Even though you explicitly state that CHANGES is in the distribution, try to avoid referring readers to anything in work/. > Xman/man3/ldap_bind_s.3.gz > Xman/man3/ldap_simple_bind.3.gz There should not be any (_any_) manpages listed in pkg/DESCR. Remove them. Use either MANx or MLINKS as appropriate. Because of the large number of manpages, your port is also a candidate for listing them outside of the Makefile (this leaves the Makefile is a somewhat more readable state). See the latest graphics/EZWGL for an example of how to do this. Note that the file files/manpages is sorted alphabetically. Please maintain this, since it you hardly even need to type 10 extra keys to do this. > X # > X! LDAP_PREFIX?= /usr/local [...] > X! LDAP_PREFIX?= ${PREFIX} > X LDAP_INSTROOT?= $(LDAP_PREFIX) MAKE_ENV= LDAP_PREFIX=${PREFIX} and/or CONFIGURE_ENV= LDAP_PREFIX=${PREFIX} Didn't work? -- This .sig is not innovative, witty, or profund. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message