From owner-freebsd-scsi@FreeBSD.ORG Wed Sep 26 15:57:14 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8F7C106566C for ; Wed, 26 Sep 2012 15:57:14 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 695FC8FC0A for ; Wed, 26 Sep 2012 15:57:14 +0000 (UTC) Received: by vbmv11 with SMTP id v11so1058958vbm.13 for ; Wed, 26 Sep 2012 08:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=C+BZgUn6gccCGIuJxHefYqyDhuOrydjPYJfcopKH8DI=; b=PkCX6ypgpwKTjjXKkrGo4eqFmkbtFx4hXhzsjFsZnYupWpRskIQzP/XKNRApxL42D2 6ataolyhuN3QGTQdS8+eD9+P9JDa4EsTE2nWis33MTaxZTNFJufPJ7q4kAP31rdBORy3 e3kNyJkNEw+fZkCKpnLxP6NyF2RU+o/35teyU7f24zHiOVkMjj1pRxtlr/tXqIkv7eOB ZwYvxX6EpOoGv2OVKmhx2P3Hq3hktLTGJz2TLu+xq7qYq6UHDBINnhqxUk+pMlDe10oF nO0aH5h2M3dUF/y/NSU7m5Wou1iW3rLwAM0UWjTpem+0laW8Yevw3ckuphuWHHinHN8u IHKw== MIME-Version: 1.0 Received: by 10.52.69.47 with SMTP id b15mr397286vdu.116.1348675033565; Wed, 26 Sep 2012 08:57:13 -0700 (PDT) Sender: jim.harris@gmail.com Received: by 10.59.10.98 with HTTP; Wed, 26 Sep 2012 08:57:13 -0700 (PDT) In-Reply-To: <20120926093759.299750@gmx.net> References: <20120923140816.144270@gmx.net> <20120926093759.299750@gmx.net> Date: Wed, 26 Sep 2012 08:57:13 -0700 X-Google-Sender-Auth: Y0fkAYjRZrp0YwE5us6ZZ9qO5fY Message-ID: From: Jim Harris To: Paul Maulberger Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-scsi@freebsd.org Subject: Re: Intel C600 SAS Controller + locate LED (SGPIO) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 15:57:14 -0000 On Wed, Sep 26, 2012 at 2:37 AM, Paul Maulberger w= rote: > Hi Jim, > > your patch is working very well. Thanks a lot! > > To support the locate and the fault led I extended your patch a little bi= t. Like the ahci driver every port has now a locate and a fault led device. Hi Paul, I am reluctant to add LEDs for error, even though I know AHCI driver does this today. I don't see the need for userspace to manipulate both locate and error LEDs - it seems locate is sufficient. I'd prefer to keep error LED reserved for future use in the driver. But I will add "locate" to the LED name, just to make it more clear. > # ls -al /dev/led > total 1 > dr-xr-xr-x 2 root wheel 512 Sep 26 08:39 . > dr-xr-xr-x 11 root wheel 512 Sep 26 10:39 .. > crw------- 1 root wheel 0, 47 Sep 26 08:43 ahcich0.fault > crw------- 1 root wheel 0, 46 Sep 26 08:44 ahcich0.locate > crw------- 1 root wheel 0, 49 Sep 26 08:39 ahcich1.fault > crw------- 1 root wheel 0, 48 Sep 26 08:39 ahcich1.locate > crw------- 1 root wheel 0, 51 Sep 26 08:39 ahcich2.fault > crw------- 1 root wheel 0, 50 Sep 26 08:39 ahcich2.locate > crw------- 1 root wheel 0, 53 Sep 26 08:39 ahcich3.fault > crw------- 1 root wheel 0, 52 Sep 26 08:39 ahcich3.locate > crw------- 1 root wheel 0, 55 Sep 26 08:39 ahcich4.fault > crw------- 1 root wheel 0, 54 Sep 26 08:39 ahcich4.locate > crw------- 1 root wheel 0, 57 Sep 26 08:44 ahcich5.fault > crw------- 1 root wheel 0, 56 Sep 26 08:44 ahcich5.locate > crw------- 1 root wheel 0, 36 Sep 26 08:39 igb0 > crw------- 1 root wheel 0, 37 Sep 26 08:39 igb1 > crw------- 1 root wheel 0, 38 Sep 26 08:39 isci.bus0.port0.fault > crw------- 1 root wheel 0, 39 Sep 26 08:39 isci.bus0.port0.locate > crw------- 1 root wheel 0, 40 Sep 26 08:42 isci.bus0.port1.fault > crw------- 1 root wheel 0, 41 Sep 26 08:42 isci.bus0.port1.locate > crw------- 1 root wheel 0, 42 Sep 26 08:39 isci.bus0.port2.fault > crw------- 1 root wheel 0, 43 Sep 26 08:39 isci.bus0.port2.locate > crw------- 1 root wheel 0, 44 Sep 26 08:39 isci.bus0.port3.fault > crw------- 1 root wheel 0, 45 Sep 26 08:39 isci.bus0.port3.locate > > By the way the main board X9DRi-F has only one bus. The X9DR3-F has 2 bus= es. > > The patch (compared to 9.1 RC1) is attached. > > Is it possible to commit this patch into 9.1 or is it too late? I think it is too late. The changes here are very low risk, but it is a new feature and not a bug fix so not really appropriate for 9.1 at this point. Thank you for testing the patch! Regards, -Jim > Regards > Paul > > Hint: If anybody is using a SC825TQ chassis and no led is blinking check = ALL jumper settings of your backplane (Appendix C of http://www.supermicro.= com/manuals/chassis/2U/SC825.pdf). Our backplane was wrongly configured by = factory (mixture of sgpio and i2c settings). > >