Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Oct 2020 04:06:41 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   [Bug 250379] www/py-cherrypy: fails to import with lang/python38 or later
Message-ID:  <bug-250379-21822-QGPQN5rtJc@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-250379-21822@https.bugs.freebsd.org/bugzilla/>
References:  <bug-250379-21822@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250379

--- Comment #5 from Jan Beich <jbeich@FreeBSD.org> ---
Comment on attachment 218781
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D218781
Patch ported from upstream

> +.if ${PYTHON_REL} >=3D 3800
[..]=20
>  .if ${PYTHON_REL} < 3800
>  RUN_DEPENDS+=3D	${PYTHON_PKGNAMEPREFIX}contextlib2>0:devel/py-contextlib=
2@${PY_FLAVOR}

Why is devel/py-contextlib2 disabled for python >=3D 3.8? "import cherrypy"
survives with external "contextlib2" under lang/python39.

Why python 3.6 and 3.7 cannot use default "contextlib" instead of
"contextlib2"? "import cherrypy" survives with "contextlib" patches.
https://contextlib2.readthedocs.io/en/stable/ says "contextlib2" is a backp=
ort
of "contextlib" from python 3.6, so it shouldn't be necessery with
lang/python36 while lang/python35 and older are no longer in the ports tree.

> +EXTRA_PATCHES+=3D	${FILESDIR}/extra-patch-cherrypy_lib_sessions.py
> +EXTRA_PATCHES+=3D	${FILESDIR}/extra-patch-setup.py

Maybe combine into one file and document the patch origin in the header.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-250379-21822-QGPQN5rtJc>