From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Dec 6 07:40:05 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FA8716A4CE for ; Sat, 6 Dec 2003 07:40:05 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3459443FE0 for ; Sat, 6 Dec 2003 07:40:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hB6Fe3FY009417 for ; Sat, 6 Dec 2003 07:40:03 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hB6Fe3n1009416; Sat, 6 Dec 2003 07:40:03 -0800 (PST) (envelope-from gnats) Resent-Date: Sat, 6 Dec 2003 07:40:03 -0800 (PST) Resent-Message-Id: <200312061540.hB6Fe3n1009416@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthias Andree Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27E7916A4CE; Sat, 6 Dec 2003 07:35:35 -0800 (PST) Received: from mail.dt.e-technik.uni-dortmund.de (krusty.dt.E-Technik.Uni-Dortmund.DE [129.217.163.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98EDF43FDD; Sat, 6 Dec 2003 07:35:32 -0800 (PST) (envelope-from matthias.andree@gmx.de) Received: from m2a2.dyndns.org (krusty.dt.e-technik.uni-dortmund.de [129.217.163.1])6976313DA1; Sat, 6 Dec 2003 16:35:31 +0100 (CET) Received: from libertas.emma.line.org (libertas.emma.line.org [192.168.0.2]) by merlin.emma.line.org (Postfix) with ESMTP id 20C069E4C1; Sat, 6 Dec 2003 16:35:30 +0100 (CET) Received: from emma by libertas.emma.line.org with local (Exim 4.24; FreeBSD) id 1AScA9-0005Qw-Dj; Sat, 06 Dec 2003 14:07:57 +0100 Message-Id: Date: Sat, 06 Dec 2003 14:07:57 +0100 From: Matthias Andree Sender: Matthias Andree To: FreeBSD-gnats-submit@FreeBSD.org, re@FreeBSD.org, portmgr@FreeBSD.org, portsmgr@FreeBSD.org X-Send-Pr-Version: 3.113 cc: dwcjr@FreeBSD.org Subject: ports/59990: [PATCH] net/samba: register popt dependency X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Dec 2003 15:40:05 -0000 >Number: 59990 >Category: ports >Synopsis: [PATCH] net/samba: register popt dependency >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Dec 06 07:40:02 PST 2003 >Closed-Date: >Last-Modified: >Originator: Matthias Andree >Release: FreeBSD 4.9-STABLE i386 >Organization: >Environment: System: FreeBSD libertas.emma.line.org 4.9-STABLE FreeBSD 4.9-STABLE #63: Sat Dec 6 13:32:32 CET >Description: This patch adds a LIB_DEPENDS line for popt. Please add this patch to the 5.2 ports and move the tag. re@ and portmgr@ are Cc'd -- please approve or reject. REASONS: 1. Samba's ./configure will automatically pull in the system popt if popt is installed when Samba (as port) is compiled, without registering it as a dependency. This means popt can later be removed without complaint, but this may break Samba. (Has been observed live on my system). 2. If Samba uses popt, we should use a system-wide shared object rather than letting Samba link against a local popt copy locally, to decrease the number of recompiles should there be a cricital popt bug discovered in the future. I am not aware of any such current issue, this is to increase maintainability. Port maintainer (dwcjr@FreeBSD.org) is also cc'd. Generated with FreeBSD Port Tools 0.50 >How-To-Repeat: >Fix: --- samba-2.2.8a.patch begins here --- diff -ruN --exclude=CVS /usr/ports/net/samba/Makefile /root/samba/Makefile --- /usr/ports/net/samba/Makefile Wed Nov 26 21:38:29 2003 +++ /root/samba/Makefile Sat Dec 6 13:43:30 2003 @@ -111,6 +111,8 @@ CONFIGURE_ARGS+= --with-msdfs .endif +LIB_DEPENDS+= popt.0:${PORTSDIR}/devel/popt + .if defined(WITH_LDAP) LIB_DEPENDS+= ldap.2:${PORTSDIR}/net/openldap20-client CONFIGURE_ARGS+= --with-ldapsam --- samba-2.2.8a.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: