From owner-freebsd-net@FreeBSD.ORG  Wed Sep 26 11:09:13 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E24941065673
	for <freebsd-net@freebsd.org>; Wed, 26 Sep 2012 11:09:13 +0000 (UTC)
	(envelope-from oppermann@networx.ch)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 5371C8FC15
	for <freebsd-net@freebsd.org>; Wed, 26 Sep 2012 11:09:12 +0000 (UTC)
Received: (qmail 18277 invoked from network); 26 Sep 2012 12:45:27 -0000
Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2])
	(envelope-sender <oppermann@networx.ch>)
	by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
	for <vijju.singh@gmail.com>; 26 Sep 2012 12:45:27 -0000
Message-ID: <5062E0BC.1010603@networx.ch>
Date: Wed, 26 Sep 2012 13:02:20 +0200
From: Andre Oppermann <oppermann@networx.ch>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Vijay Singh <vijju.singh@gmail.com>
References: <CALCNsJSWadFMxC831mH9BnJCTvimjwtAJnnTUuUdGms+vVjuXg@mail.gmail.com>
In-Reply-To: <CALCNsJSWadFMxC831mH9BnJCTvimjwtAJnnTUuUdGms+vVjuXg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
Subject: Re: M_TRAILINGSPACE()
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2012 11:09:14 -0000

On 26.09.2012 02:55, Vijay Singh wrote:
> Folks, does the following patch make sense:
>
> server@[/u/vijay/bsd/CODE/cur/sys/sys]# svn diff mbuf.h
> Index: mbuf.h
> ===================================================================
> --- mbuf.h	(revision 240548)
> +++ mbuf.h	(working copy)
> @@ -832,6 +832,8 @@
>   	((m)->m_flags & M_EXT ?						\
>   	    (M_WRITABLE(m) ? (m)->m_ext.ext_buf + (m)->m_ext.ext_size	\
>   		- ((m)->m_data + (m)->m_len) : 0) :			\
> +	    (m)->m_flags & M_PKTHDR ? 					\
> +	    ((m)->m_pktdat[MHLEN] - ((m)->m_data + (m)->m_len)) : 	\
>   	    &(m)->m_dat[MLEN] - ((m)->m_data + (m)->m_len))

Isn't this the same result in both cases? And isn't there a '&' missing?

-- 
Andre