From owner-cvs-src@FreeBSD.ORG Tue Aug 1 01:17:40 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 225E016A4DA; Tue, 1 Aug 2006 01:17:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8704C43D49; Tue, 1 Aug 2006 01:17:39 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k711FZEI033003; Mon, 31 Jul 2006 19:15:35 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 31 Jul 2006 19:15:58 -0600 (MDT) Message-Id: <20060731.191558.-1253045041.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20060731163209.GB50797@comp.chem.msu.su> References: <20060731140951.GC48538@comp.chem.msu.su> <20060731163209.GB50797@comp.chem.msu.su> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 31 Jul 2006 19:15:36 -0600 (MDT) Cc: marcel@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, marcel@xcllnt.net, src-committers@freebsd.org, ru@freebsd.org Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 01:17:40 -0000 In message: <20060731163209.GB50797@comp.chem.msu.su> Yar Tikhiy writes: : On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote: : > : > On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote: : > : > >On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: : > >>marcel 2006-07-30 20:51:41 UTC : > >> : > >> FreeBSD src repository : > >> : > >> Modified files: : > >> usr.sbin/kldxref Makefile : > >> Log: : > >> Use NO_SHARED=YES to force a static link. : > >> : > >> Pointed out by: ru@ : > >> : > >> Revision Changes Path : > >> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile : > > : > >Perhaps it should be spelled just ``NO_SHARED='' in keeping with : > >the current style? : > : > I really don't know. Those NO_FOO knobs are not logical in their : > use. : > : > > Unfortunately style.Makefile(5) doesn't seem : > >to list this rule... : > : > Feel free to change my commit to whatever you think is right. : : I was sly enough to add Ruslan to Cc in my previous mail :-) : Let's wait for his opinion on this and below. : : In the meanwhile I peeked in /usr/share/mk and found that the handling : of NO_* knobs is quite far from being consistent. For example: : : - NO_MAN -- can be just defined ("YES" and "NO" both mean true), : handled at level (note that : is often included separately now and includes some magic); : : - NO_OBJ -- can be just defined to be true, handled in , : which is included from more convenient files like ; : : - NO_SHARED -- must be set to something != "no" for the effect, : handled in . : : I'm unsure if there is a reason behind all this diversity. Hysterical Raisons. It all started out '.if defined(NO_FOO)' or '.if !defined(NO_FOO)'. This is why NO_OBJ and NO_MAN are that way. Then people wanted to override the global default to force things to be linked statically. This was so that things like init could always be static back in the day. This accounts for NO_SHARED handling. It is a miss-mash. That's why we're not supposed to set NO_FOO anymore. MK_FOO is set to yes or no depending on defaults and WITH/WITHOUT_FOO. I'm not sure why ru@ didn't include the above in his big cleanup. Warner