Date: Wed, 8 Feb 2017 12:31:46 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Emmanuel Vadot <manu@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313394 - head/sys/kern Message-ID: <20170208120650.T1171@besplex.bde.org> In-Reply-To: <201702071731.v17HVOtQ081967@repo.freebsd.org> References: <201702071731.v17HVOtQ081967@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 7 Feb 2017, Emmanuel Vadot wrote: > Log: > subr_sfbus.c need sys/proc.h for struct thread definition. > This fixes kernel build for armv6. > > Discussed with: kib sys/proc.h was accidentally (?) provided by gross namespace pollution on some arches (perhaps on all the arches that use subr_sfbuf.c) in <machine/counter.h>. This pollution is only supplied under INVARIANTS, so it is not completely accidental. However, at least on i386, sys/proc.h and its nested pollution isn't even used for anything except to pollute. <machine/counter.h> has lots of other undocumented pollution which is actually partially used (mainly sys/pcpu.h and its pollution). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170208120650.T1171>