From nobody Sat Mar 19 20:11:38 2022 X-Original-To: ruby@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D50FD1A2F243; Sat, 19 Mar 2022 20:11:43 +0000 (UTC) (envelope-from SRS0=/PPU=T6=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from anny.lostinspace.de (anny.lostinspace.de [IPv6:2001:608:a02::33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KLX8Z450Mz3NQD; Sat, 19 Mar 2022 20:11:42 +0000 (UTC) (envelope-from SRS0=/PPU=T6=FreeBSD.org=mfechner@anny.lostinspace.de) Received: from server.idefix.lan (194-153-117-131.ip-addr.inexio.net [131.117.153.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: idefix@fechner.net) by anny.lostinspace.de (Postfix) with ESMTPSA id 9683CB085C; Sat, 19 Mar 2022 21:11:39 +0100 (CET) Received: from [IPV6:2a02:6d40:36c1:ac01:ade6:b11d:9916:f3d0] (unknown [IPv6:2a02:6d40:36c1:ac01:ade6:b11d:9916:f3d0]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by server.idefix.lan (Postfix) with ESMTPSA id 8EA8A11FBD9; Sat, 19 Mar 2022 21:11:38 +0100 (CET) Message-ID: Date: Sat, 19 Mar 2022 21:11:38 +0100 List-Id: FreeBSD-specific Ruby discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ruby List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ruby@freebsd.org X-BeenThere: freebsd-ruby@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Yasuhiro Kimura , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org, ruby References: <202203190724.22J7ORvX057952@gitrepo.freebsd.org> From: Matthias Fechner Subject: Re: git: c22b848a5d76 - 2022Q1 - mail/rubygem-mail: Fix dependency with Ruby 3.1 In-Reply-To: <202203190724.22J7ORvX057952@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: anny.lostinspace.de X-Rspamd-Queue-Id: 4KLX8Z450Mz3NQD X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of "SRS0=/PPU=T6=FreeBSD.org=mfechner@anny.lostinspace.de" designates 2001:608:a02::33 as permitted sender) smtp.mailfrom="SRS0=/PPU=T6=FreeBSD.org=mfechner@anny.lostinspace.de" X-Spamd-Result: default: False [-3.19 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; RCVD_IN_DNSWL_MED(-0.20)[2001:608:a02::33:from]; NEURAL_HAM_SHORT(-0.99)[-0.994]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-branches,ruby]; FORGED_SENDER(0.30)[mfechner@FreeBSD.org,SRS0=/PPU=T6=FreeBSD.org=mfechner@anny.lostinspace.de]; RECEIVED_SPAMHAUS_PBL(0.00)[131.117.153.194:received]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5539, ipnet:2001:608::/32, country:DE]; FROM_NEQ_ENVFROM(0.00)[mfechner@FreeBSD.org,SRS0=/PPU=T6=FreeBSD.org=mfechner@anny.lostinspace.de]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Am 19.03.2022 um 08:24 schrieb Yasuhiro Kimura: > In Ruby 3.1 net/smtp is distributed as bundled gem. On the other hand, > our ruby ports (lang/rubyXY) don't include bundled gems in their > packages and it also applies to lang/ruby31. That means net/smtp isn't > include in the package of Ruby 3.1. So add mail/rubygem-net-smtp to > RUN_DEPENDS so this port works fine with Ruby 3.1. I'm not in favor doing it this way. If you go to: https://rubygems.org/gems/mail The dependency is not listed. I think doing it this way, will will run into many runtime problems. I think it would be better to install rubyXY in a way that expected packages are existing. In my opinion we should add the runtime deps to the rubyXY port and remove these patches from the ports like mail/rubygem-mail. The next person that will upgrade mail to e.g. 2.7.2 will check https://rubygems.org/gems/mail and will remove the dependency to mail/rubygem-net-smtp again. I think this will end in a nightmare managing the dependencies correctly. Any comments? Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook