Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Oct 2020 19:35:07 +0000
From:      "ae (Andrey V. Elsukov)" <phabric-noreply@FreeBSD.org>
To:        Phabricator <phabric-noreply@FreeBSD.org>
Cc:        freebsd-net@freebsd.org
Subject:   [Differential] D26757: Fix to join AllHost mcast group again when adding an existing IP address
Message-ID:  <d7b242fce3dc80ff5f1c8827f14fce54@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-6p7swwnwsjwmyozi3buz-req@reviews.freebsd.org>
References:  <differential-rev-PHID-DREV-6p7swwnwsjwmyozi3buz-req@reviews.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
This revision was automatically updated to reflect the committed changes.
Closed by commit rS366682: Join to AllHosts multicast group again when adding an existing IPv4 address. (authored by ae).

CHANGED PRIOR TO COMMIT
  https://reviews.freebsd.org/D26757?vs=78157&id=78184#toc

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST UPDATE
  https://reviews.freebsd.org/D26757?vs=78157&id=78184

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D26757/new/

REVISION DETAIL
  https://reviews.freebsd.org/D26757

AFFECTED FILES
  head/sys/netinet/in.c

CHANGE DETAILS

diff --git a/head/sys/netinet/in.c b/head/sys/netinet/in.c
--- a/head/sys/netinet/in.c
+++ b/head/sys/netinet/in.c
@@ -377,10 +377,11 @@
 			continue;
 
 		it = (struct in_ifaddr *)ifa;
-		iaIsFirst = false;
 		if (it->ia_addr.sin_addr.s_addr == addr->sin_addr.s_addr &&
 		    prison_check_ip4(td->td_ucred, &addr->sin_addr) == 0)
 			ia = it;
+		else
+			iaIsFirst = false;
 	}
 	NET_EPOCH_EXIT(et);
 



EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: yannis.planus_alstomgroup.com, #network, mw, ae, gnn
Cc: ae, imp, freebsd-net-list, melifaro, rscheff

[-- Attachment #2 --]
diff --git a/head/sys/netinet/in.c b/head/sys/netinet/in.c
--- a/head/sys/netinet/in.c
+++ b/head/sys/netinet/in.c
@@ -377,10 +377,11 @@
 			continue;
 
 		it = (struct in_ifaddr *)ifa;
-		iaIsFirst = false;
 		if (it->ia_addr.sin_addr.s_addr == addr->sin_addr.s_addr &&
 		    prison_check_ip4(td->td_ucred, &addr->sin_addr) == 0)
 			ia = it;
+		else
+			iaIsFirst = false;
 	}
 	NET_EPOCH_EXIT(et);
 


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d7b242fce3dc80ff5f1c8827f14fce54>