From owner-cvs-all@FreeBSD.ORG Thu Dec 13 02:52:59 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 738DA16A4C6; Thu, 13 Dec 2007 02:52:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 212EC13C459; Thu, 13 Dec 2007 02:52:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8r) with ESMTP id 224200794-1834499 for multiple; Wed, 12 Dec 2007 21:53:04 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lBD2qqCO085918; Wed, 12 Dec 2007 21:52:52 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Doug Barton Date: Wed, 12 Dec 2007 20:41:16 -0500 User-Agent: KMail/1.9.6 References: <200712130051.lBD0p1ZY011259@repoman.freebsd.org> <476088C3.9090207@FreeBSD.org> In-Reply-To: <476088C3.9090207@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712122041.17462.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 12 Dec 2007 21:52:53 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5110/Wed Dec 12 15:42:31 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/rc.d ldconfig X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2007 02:52:59 -0000 On Wednesday 12 December 2007 08:20:03 pm Doug Barton wrote: > John Baldwin wrote: > > jhb 2007-12-13 00:51:01 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc/rc.d ldconfig > > Log: > > Only pass paths to directories or config files that exist for ldconfig for > > 32-bit binaries. > > > > MFC after: 3 days > > > > Revision Changes Path > > 1.19 +8 -2 src/etc/rc.d/ldconfig > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/ldconfig.diff?&r1=1.18&r2=1.19&f=h > > > > I'm not saying this is a bad idea, but doesn't ldconfig ignore stuff > that doesn't exist? As for the test, I think you might want -x instead > of -r. It emits a warning on the console and this shuts up that warning. I used -r to match what we do for the two other places in this script when we sanity check the paths to pass to ldconfig. -- John Baldwin