From owner-svn-src-head@FreeBSD.ORG Mon Mar 18 14:22:15 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0FC3F61C; Mon, 18 Mar 2013 14:22:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id D1810D9B; Mon, 18 Mar 2013 14:22:14 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 29106B968; Mon, 18 Mar 2013 10:22:14 -0400 (EDT) From: John Baldwin To: Rui Paulo Subject: Re: svn commit: r247814 - in head: . sys/amd64/conf sys/cam/ctl sys/conf sys/i386/conf Date: Mon, 18 Mar 2013 09:42:03 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201303042118.r24LIj5e008913@svn.freebsd.org> <201303131108.27005.jhb@freebsd.org> <6B59A612-B737-4E1F-AF56-0DA1D0733F0A@FreeBSD.org> In-Reply-To: <6B59A612-B737-4E1F-AF56-0DA1D0733F0A@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201303180942.03814.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 18 Mar 2013 10:22:14 -0400 (EDT) Cc: svn-src-head@freebsd.org, "Kenneth D. Merry" , svn-src-all@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2013 14:22:15 -0000 On Saturday, March 16, 2013 12:54:01 pm Rui Paulo wrote: > On 2013/03/13, at 8:08, John Baldwin wrote: > > > On Tuesday, March 12, 2013 5:09:21 pm Pawel Jakub Dawidek wrote: > >> On Mon, Mar 04, 2013 at 09:18:45PM +0000, Kenneth D. Merry wrote: > >>> Author: ken > >>> Date: Mon Mar 4 21:18:45 2013 > >>> New Revision: 247814 > >>> URL: http://svnweb.freebsd.org/changeset/base/247814 > >>> > >>> Log: > >>> Re-enable CTL in GENERIC on i386 and amd64, but turn on the CTL disable > >>> tunable by default. > >>> > >>> This will allow GENERIC configurations to boot on small memory boxes, but > >>> not require end users who want to use CTL to recompile their kernel. They > >>> can simply set kern.cam.ctl.disable=0 in loader.conf. > >> > >> Could you rename it to kern.cam.ctl.enable(d)? There was discussion at > >> some point about sysctl/tunable names and the consensus was, AFAIR, to > >> use positive(?) names as they are more obvious. > > > > Except that all the hints we use for devices are hint.foo.X.disable=1 :) > > > I think this is not correct. The `disabled' hint comes from > resource_disabled(), which checks for > "resource_int_value(name, unit, "disabled", &value);" Yes, it probably is disabled rather than disable, but the point about it being a negative "disable" hint vs a positive "enable" hint still stands. -- John Baldwin