Date: Sun, 8 Apr 2012 08:21:20 -0800 (AKDT) From: Mel Flynn <rflynn@acsalaska.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: Steve Wills <swills@FreeBSD.org>, Maintainer <kuriyama@FreeBSD.org> Subject: ports/166758: [patch] devel/p5-Perl-Metrics-Simple: fix tests Message-ID: <201204081621.q38GLKhx091110@datakitty.lan.rachie.is-a-geek.net> Resent-Message-ID: <201204081630.q38GUDod067793@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166758
>Category: ports
>Synopsis: [patch] devel/p5-Perl-Metrics-Simple: fix tests
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Apr 08 16:30:13 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Mel Flynn
>Release: FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD datakitty.lan.rachie.is-a-geek.net 8.2-STABLE FreeBSD 8.2-STABLE #6 r230977: Sun Feb 5 06:20:11 AKST 2012 mel@datakitty.lan.rachie.is-a-geek.net:/data/obj/data/RELENG_8/src/sys/GENERIC amd64
>Description:
The FreeBSD port for this module contains a customization that adds the
starting line number of a subroutine to the analyze hash.
The test data does not reflect this customization making the test fail.
Also, the test suite does not currently skip the availibility of
p5-Test-Pod-Coverage correctly, so a quick fix is to add the module to the
TEST_DEPENDS.
>How-To-Repeat:
cd /usr/ports/devel/p5-Perl-Metrics-Simple
make build
cd `make -V WRKSRC`
make test
>Fix:
--- devel__p5-Perl-Metrics-Simple.patch begins here ---
diff -urN --exclude CVS --exclude '*~' devel/p5-Perl-Metrics-Simple/Makefile /usr/ports/devel/p5-Perl-Metrics-Simple/Makefile
--- devel/p5-Perl-Metrics-Simple/Makefile.orig 2011-12-30 23:42:17.000000000 -0900
+++ devel/p5-Perl-Metrics-Simple/Makefile 2012-04-07 17:25:36.000000000 -0800
@@ -19,6 +19,8 @@
p5-Readonly>=1.03:${PORTSDIR}/devel/p5-Readonly \
p5-Statistics-Basic>0:${PORTSDIR}/math/p5-Statistics-Basic
BUILD_DEPENDS= ${RUN_DEPENDS}
+TEST_DEPENDS+= p5-Test-Pod>0:${PORTSDIR}/devel/p5-Test-Pod \
+ p5-Test-Pod-Coverage>0:${PORTSDIR}/devel/p5-Test-Pod-Coverage
PERL_CONFIGURE= yes
diff -urN --exclude CVS --exclude '*~' devel/p5-Perl-Metrics-Simple/files/patch-t__lib__Perl__Metrics__Simple__TestData.pm /usr/ports/devel/p5-Perl-Metrics-Simple/files/patch-t__lib__Perl__Metrics__Simple__TestData.pm
--- devel/p5-Perl-Metrics-Simple/files/patch-t__lib__Perl__Metrics__Simple__TestData.pm.orig 1969-12-31 14:00:00.000000000 -1000
+++ devel/p5-Perl-Metrics-Simple/files/patch-t__lib__Perl__Metrics__Simple__TestData.pm 2012-04-07 17:19:58.000000000 -0800
@@ -0,0 +1,39 @@
+--- t/lib/Perl/Metrics/Simple/TestData.pm.orig 2010-05-12 16:52:52.000000000 -0800
++++ t/lib/Perl/Metrics/Simple/TestData.pm 2012-04-07 17:19:58.000000000 -0800
+@@ -127,12 +127,14 @@
+ name => 'foo',
+ lines => 1,
+ mccabe_complexity => 1,
++ line_number => 10,
+ path => "$test_directory/subs_no_package.pl",
+ },
+ {
+ name => 'bar',
+ lines => 2,
+ mccabe_complexity => 1,
++ line_number => 11,
+ path => "$test_directory/subs_no_package.pl",
+ }
+ ],
+@@ -152,18 +154,21 @@
+ name => 'new',
+ lines => 5,
+ mccabe_complexity => 1,
++ line_number => 8,
+ path => "$test_directory/Perl/Code/Analyze/Test/Module.pm",
+ },
+ {
+ name => 'foo',
+ lines => 9,
+ mccabe_complexity => 8,
++ line_number => 14,
+ path => "$test_directory/Perl/Code/Analyze/Test/Module.pm",
+ },
+ {
+ name => 'say_hello',
+ lines => 9,
+ mccabe_complexity => 5,
++ line_number => 26,
+ path => "$test_directory/Perl/Code/Analyze/Test/Module.pm",
+ },
+ ],
--- devel__p5-Perl-Metrics-Simple.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204081621.q38GLKhx091110>