Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Mar 2019 16:15:45 +0000 (UTC)
From:      Adam Weinberger <adamw@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r496270 - head/editors/py-pynvim
Message-ID:  <201903191615.x2JGFjvG014699@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adamw
Date: Tue Mar 19 16:15:44 2019
New Revision: 496270
URL: https://svnweb.freebsd.org/changeset/ports/496270

Log:
  Remove neovim from TEST_DEPENDS, and original submitter becomes maintainer
  
  My intention is to add an OPTION for pynvim to the neovim port, which
  means that this port cannot depend upon neovim. Change do-test to a
  maintainer-test target that gives some instructions.
  
  Also, per original PR and at request of 0mp, pass maintainership to
  Thomas Merkel, the submitter of the original py-pynvim PR.
  
  PR:		236571
  Approved by:	0mp

Modified:
  head/editors/py-pynvim/Makefile

Modified: head/editors/py-pynvim/Makefile
==============================================================================
--- head/editors/py-pynvim/Makefile	Tue Mar 19 16:07:57 2019	(r496269)
+++ head/editors/py-pynvim/Makefile	Tue Mar 19 16:15:44 2019	(r496270)
@@ -5,7 +5,7 @@ PORTVERSION=	0.3.2
 CATEGORIES=	editors python
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 
-MAINTAINER=	0mp@FreeBSD.org
+MAINTAINER=	tm@NetBSD.org
 COMMENT=	Python client and plugin host for Neovim
 
 LICENSE=	APACHE20
@@ -14,8 +14,7 @@ LICENSE_FILE=	${WRKSRC}/LICENSE
 RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}msgpack>=0.5.0:devel/py-msgpack@${PY_FLAVOR} \
 		${PYTHON_PKGNAMEPREFIX}greenlet>=0:devel/py-greenlet@${PY_FLAVOR}
 py27_RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}trollius>=0:devel/py-trollius@${PY_FLAVOR}
-TEST_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pytest>=3.4.0:devel/py-pytest@${PY_FLAVOR} \
-		nvim:editors/neovim
+TEST_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pytest>=3.4.0:devel/py-pytest@${PY_FLAVOR}
 
 USES=		python
 USE_PYTHON=	concurrent distutils flavors autoplist
@@ -29,7 +28,9 @@ SUB_FILES=	pkg-message
 SUB_LIST=	PYTHON_CMD=${PYTHON_CMD} \
 		SUFFIX_FOR_PYTHON_3=${PYTHON_MAJOR_VER:M3}
 
-do-test:
-	cd ${WRKSRC} && ${PYTHON_CMD} -m pytest
+maintainer-test:
+# Cannot depend on neovim as it could create a circular dependency
+	@${ECHO_CMD} "===> Install neovim, then run:"
+	@${ECHO_CMD} "cd ${WRKSRC} && ${PYTHON_CMD} -m pytest"
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903191615.x2JGFjvG014699>