From nobody Thu Sep 21 17:19:38 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rs2Fk5w4xz4tk50; Thu, 21 Sep 2023 17:19:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rs2Fk4P1sz4fCN; Thu, 21 Sep 2023 17:19:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695316778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6Tq6/X3RYVYgKs4VWSVx4PF5lF59wqye80hqKHQNY5Q=; b=C6VWHHm3jKL8Kb5hQ8Iy85qGOwH4x1M75khOwwYiYirtdoZHQUn0iqrUW5aLQJkyhEqiTa 7IxdaEWux9ni2kJZvYL/koaNvi1/NPPljto4PRH5Fyhx7OQEModIFVjjPPYlXXwdXWz8z2 eF6G0KA4JMKSe+9pGb1t33VMJwn8J2rPxw8Sfme0dy/pOseD46OAXAqaPpO2C/QN/3Mj/G wGu6PZFpzH8RmAf8+lKxk34BcOXkputkHI55XAwJNuiSVuRifeXYxMMy1ogIxpTZmon845 haTJKKs7zuLQThotCoOd0xWQ6K613YvLIlcCnA7XUARn+0nB+CqvYQXyBKJSsA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695316778; a=rsa-sha256; cv=none; b=EH5wiw78vzOoZpkmnLkj/iU97RMXoL/7I5oZsnVel7GCNHzd3YfeaC3dRtiCTe1GAgoEQb kZZDmWQPdUa+VeCe+OglKiOvhLAy5ySiK961NODVwSGcF8kkVnkZwEMGJqPCukf6J0j41f 4jlRfT3WN9GA6A0Z5v41H9SNNOCrn0FztTAN5QUCWgUDDYLcqC/hJ1P+DkQ7VkkeiucXqf nV+JPY6tE3mbNVgmQGTCGfGQU6pr3Qsg2fSkGSMes5IIpQshwLS1TNXoQZzGKxqmLPR/kO WSJGilPDFYhNbW5DjfEBBGBDO270aYaBYXOFO6xowF3/jYK/kYEhrF5bQezjrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695316778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6Tq6/X3RYVYgKs4VWSVx4PF5lF59wqye80hqKHQNY5Q=; b=AEmJVAewemXqE5rNahlo9iIBAv7ZeOL0awQohV6EOqw04gbm2UfRhu4l8OkujpCru3eF7f eSmchz3raQZjzIjx2oMTKP/LlKtvbvYDaYo4/adMAV0USCSam9b7CZ/duoTEjyxFxWS+sA 6YflhGWc+uhQqvh9lWLMUhKWjdbxRUzFgN3feDwgFLKbbOvbvB/sUE35gX12DwKpL71f4A pQBbM+npoha3qiLC1J6rqvUU+5pqYANqNSB4K5X1PD8hyZygqSchPembixhXytUNvLhQm+ pBtAe2GXnJmmUwzqqDktkclet0ByYuCFg9Vrezq2HwLAsG6mRDPBmpZ5th2m6g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rs2Fk24wFzn3d; Thu, 21 Sep 2023 17:19:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38LHJcSK076512; Thu, 21 Sep 2023 17:19:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38LHJcPs076509; Thu, 21 Sep 2023 17:19:38 GMT (envelope-from git) Date: Thu, 21 Sep 2023 17:19:38 GMT Message-Id: <202309211719.38LHJcPs076509@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 8d58a0578635 - main - LinuxKPI: 802.11: change ic_parent() to not call mo_stop()/mo_start() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8d58a0578635dc7dd1025ab08b0479f2b383e1a4 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=8d58a0578635dc7dd1025ab08b0479f2b383e1a4 commit 8d58a0578635dc7dd1025ab08b0479f2b383e1a4 Author: Bjoern A. Zeeb AuthorDate: 2023-09-21 12:25:20 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-09-21 17:08:48 +0000 LinuxKPI: 802.11: change ic_parent() to not call mo_stop()/mo_start() Driven by net80211 we may call mac80211 ops stop() and start() mostly when toggling a first VAP. While this is FreeBSD behaviour the firmware based LinuxKPI drivers seem to possibly clear state in the case of stop() triggering further errors down the line. We call mo_start() when starting the VAP and mo_stop() when destroying it now only. In the future (e.g., in multi-VAP setups) we may need to re-address some of this so keep the code under #ifdef. Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/compat/linuxkpi/common/src/linux_80211.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 1fc9f9bcba15..b97e1c196867 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -2460,24 +2460,32 @@ static void lkpi_ic_parent(struct ieee80211com *ic) { struct lkpi_hw *lhw; +#ifdef HW_START_STOP struct ieee80211_hw *hw; int error; +#endif bool start_all; IMPROVE(); lhw = ic->ic_softc; +#ifdef HW_START_STOP hw = LHW_TO_HW(lhw); +#endif start_all = false; /* IEEE80211_UNLOCK(ic); */ LKPI_80211_LHW_LOCK(lhw); if (ic->ic_nrunning > 0) { +#ifdef HW_START_STOP error = lkpi_80211_mo_start(hw); if (error == 0) +#endif start_all = true; } else { +#ifdef HW_START_STOP lkpi_80211_mo_stop(hw); +#endif } LKPI_80211_LHW_UNLOCK(lhw); /* IEEE80211_LOCK(ic); */