From owner-freebsd-hackers@FreeBSD.ORG Fri Oct 22 14:56:35 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FBAB16A4CE for ; Fri, 22 Oct 2004 14:56:35 +0000 (GMT) Received: from avscan1.sentex.ca (avscan1.sentex.ca [199.212.134.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id D37DA43D2F for ; Fri, 22 Oct 2004 14:56:34 +0000 (GMT) (envelope-from mike@sentex.net) Received: from localhost (localhost.sentex.ca [127.0.0.1]) by avscan1.sentex.ca (8.12.11/8.12.11) with ESMTP id i9MEuYpU034026 for ; Fri, 22 Oct 2004 10:56:34 -0400 (EDT) (envelope-from mike@sentex.net) Received: from avscan1.sentex.ca ([127.0.0.1]) by localhost (avscan1.sentex.ca [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 33646-05 for ; Fri, 22 Oct 2004 10:56:33 -0400 (EDT) Received: from lava.sentex.ca (pyroxene.sentex.ca [199.212.134.18]) by avscan1.sentex.ca (8.12.11/8.12.11) with ESMTP id i9MEuXPm034012 for ; Fri, 22 Oct 2004 10:56:33 -0400 (EDT) (envelope-from mike@sentex.net) Received: from simian.sentex.net (simeon.sentex.ca [192.168.43.27]) by lava.sentex.ca (8.12.11/8.12.11) with ESMTP id i9MEuRgI079052 for ; Fri, 22 Oct 2004 10:56:28 -0400 (EDT) (envelope-from mike@sentex.net) Message-Id: <6.1.2.0.0.20041022103155.09b6d208@64.7.153.2> X-Sender: mdtpop@64.7.153.2 (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.1.2.0 Date: Fri, 22 Oct 2004 11:03:31 -0400 To: freebsd-hackers@freebsd.org From: Mike Tancsa Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Virus-Scanned: by amavisd-new X-Virus-Scanned: by amavisd-new at avscan1b Subject: fix to a data corruption problem X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 14:56:35 -0000 We are trying to fix a bug in the uhid interrupt handler/driver http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/72935 where it can inadvertently walk into another handler working with clist data structures in sys/kern/tty_subr.c. Uhid is a "bio" class device, which means that its not masked when another "tty" class handler is running. Our modification to uhid below appears to work, but we have seen references to "update_intr_masks()" as part of this type of modification. int s = splhigh(); tty_imask |= bio_imask; splx( s ); What is the "approved" method for doing this? If this is correct, any chance some one could commit the fix to RELENG_4 ? ---Mike -------------------------------------------------------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet since 1994 www.sentex.net Cambridge, Ontario Canada www.sentex.net/mike