From owner-freebsd-mips@freebsd.org Thu May 26 01:57:33 2016 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F7E4B49CD2; Thu, 26 May 2016 01:57:33 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-oi0-x22d.google.com (mail-oi0-x22d.google.com [IPv6:2607:f8b0:4003:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5C0BC19C0; Thu, 26 May 2016 01:57:33 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-oi0-x22d.google.com with SMTP id b65so102734716oia.1; Wed, 25 May 2016 18:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=FJZ23bhP1A4PZPDBtq9/57s8Ou4Jh8xpprNvK/kgxCk=; b=R1aPWBiwGZ9E06uoDmIlvSi1VXB/i8ig468SwvulFy/Pse/vMDtAURZvFq9Eytgmv1 QXgQvBDyKXuMy9hu/KrWYZd4p5lMGroR/CEx8xUJ47rTvVVVqPcziHyWcdCSoAmtYz6A hv1Hpz3aqF492CDYfb5F0R3KdbydMOnHadXxA2mUBNQ14anjaegFbepRZUkCgTViczPr azddtWWVX+al+53SgblTnZq6IkROG9S73cBsIczasYTz9OxZu/tCEq//oL7uUo/0Ac3i F55vCM8Y6wgj6NBgo/fEd5yaLDTZyFedWgi+SqDsNAB2ThXsCSrMjctQp9+Sqb3eZ9WI MHlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=FJZ23bhP1A4PZPDBtq9/57s8Ou4Jh8xpprNvK/kgxCk=; b=EEJlOmOMZemoRNI3HCIM9S/n4T0DKfC8NeXbBjAFRA1PmNmwrpE292XjX5ILcTMqMC 8NMfhSAK7FlVvk70IvxRh+nwQhnrir485eqiwM6jBDdyPY8TvjL6fgNGfUMhwBrjK/gU W8dURjNDzWyeE1CMa3+ocjJX2enmVSlQSEilBNgFwWmaJGybPolpWL58CBYKLqzT+UoZ 2/5VhnrKHKFfx2Hxq7weGTZxECkkPrJQsPzDDtsIW85/jva/jE0eVYGdOcDCBP2DFSfo AUbRpkcw5oQCOhZARfesGTHIp5A1CkM7BrIGyv5v3rWBsexi9TKiM8o2iRsYa4qwirfe U9dw== X-Gm-Message-State: ALyK8tLAiHgBKsXyL7u7L2fCp9MZT/KuLs9XqDR5gLBj153r8Gl0jj1993KqzzB82LqsgpzbwqRohDiwKyeSAQ== MIME-Version: 1.0 X-Received: by 10.202.198.129 with SMTP id w123mr3788359oif.158.1464227852468; Wed, 25 May 2016 18:57:32 -0700 (PDT) Sender: pkelsey@gmail.com Received: by 10.157.1.174 with HTTP; Wed, 25 May 2016 18:57:32 -0700 (PDT) In-Reply-To: References: <201604191539.u3JFdkHx048678@repo.freebsd.org> <20160419171243.GA30453@bsdpad.com> <1461097280.1232.34.camel@freebsd.org> Date: Wed, 25 May 2016 21:57:32 -0400 X-Google-Sender-Auth: uWfemoEgsUVBLhqaA8cin_P-tKs Message-ID: Subject: Re: svn commit: r298274 - head/sys/dev/spibus From: Patrick Kelsey To: Adrian Chadd Cc: "freebsd-mips@freebsd.org" , "freebsd-arm@freebsd.org" , Ruslan Bukin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 01:57:33 -0000 On Fri, May 20, 2016 at 2:35 AM, Adrian Chadd wrote: > I've reviewed the patches from luiz, and these look fine. but indeed, > this patchset does set/release the bus each transaction so we can do > multiple transactions whilst holding the bus. > > Which is fine, but it means I have to undo ruslan's removal in the below > commit. > > I'm happy to run through and do each of the spi bus drivers (as there > are more now than the two you patched) but it's a bit close to the > 11.0-release cycle to go and churn the spibus code. > > But, if people think it's worth doing it so we can try to get mmcspi > into the tree before 11.0-rel is cut, I'm happy to run through and do > it. I actually have some AR9331 stuff now that could use mmcspi. :) > > What do people think? > > Thanks, Adrian. My opinion is that the changes to the spi bus interface and the corresponding changes to the spi bus drivers you are talking about are very straightforward and low risk. There is non-zero other interest out there in using the mmcspi driver, based on the couple of emails I've received seeking help on the subject in the last six months or so, so I don't think this would be just a commit for the sake of getting some interesting new code in. -Patrick