From owner-cvs-ports@FreeBSD.ORG  Sat Jun 16 06:55:59 2007
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
X-Original-To: cvs-ports@freebsd.org
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5731D16A400
	for <cvs-ports@freebsd.org>; Sat, 16 Jun 2007 06:55:59 +0000 (UTC)
	(envelope-from infofarmer@gmail.com)
Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179])
	by mx1.freebsd.org (Postfix) with ESMTP id 1F11213C469
	for <cvs-ports@freebsd.org>; Sat, 16 Jun 2007 06:55:59 +0000 (UTC)
	(envelope-from infofarmer@gmail.com)
Received: by wa-out-1112.google.com with SMTP id j37so1472365waf
	for <cvs-ports@freebsd.org>; Fri, 15 Jun 2007 23:55:58 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=KkZCr7NAMjQA24WEMbwRBGaNM7OMqVR4qI0FMUaZT5oqjhMjFufnqHdskqh4WbJpBEJPm/+1HGJUu3u4MEo1UWQDryBOboN71NuG3qWnsKoIEhyWMnqo0Y6T6/OibuAqVg8vheYqxafZLUgdzikPWxmKoqOzIfuRekZUiUBMqAM=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=OwRjvhDu7IoIgrJtJYJDnlqAon6cSLHcEOgfzVLF2SgStU0vvgwk7D10UXVCv1PFZhYKXIA3hH+q/q+P/DufTtAtqNDdQoULWjdnBJLOyYTNYnA6eRelZ6ADEXewyG6pSTSSL23MxC9N3s1Q7w5r4oEy/nGYPMA7vL0Hgtipu00=
Received: by 10.114.73.1 with SMTP id v1mr3940806waa.1181976958901;
	Fri, 15 Jun 2007 23:55:58 -0700 (PDT)
Received: by 10.114.194.5 with HTTP; Fri, 15 Jun 2007 23:55:58 -0700 (PDT)
Message-ID: <cb5206420706152355p58660750h16803d72085be0c3@mail.gmail.com>
Date: Sat, 16 Jun 2007 10:55:58 +0400
From: "Andrew Pantyukhin" <infofarmer@FreeBSD.org>
Sender: infofarmer@gmail.com
To: "Alexey Dokuchaev" <danfe@freebsd.org>
In-Reply-To: <20070616063243.GA9047@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200706152057.l5FKv26c070603@repoman.freebsd.org>
	<20070615210224.3C6A116A5D1@hub.freebsd.org>
	<cb5206420706151420i4c9f0a97q85ddf9b74d338bda@mail.gmail.com>
	<1181947632.52923.7.camel@ikaros.oook.cz>
	<cb5206420706152323m4215a8eay94a7d70b6225de2b@mail.gmail.com>
	<20070616063243.GA9047@FreeBSD.org>
X-Google-Sender-Auth: 24dfe8e7e1281717
Cc: cvs-ports@freebsd.org, pav@freebsd.org, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/graphics/tcm Makefile pkg-message
	ports/graphics/tcm/files patch-debian-gcc4 pkg-message.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jun 2007 06:55:59 -0000

On 6/16/07, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sat, Jun 16, 2007 at 10:23:09AM +0400, Andrew Pantyukhin wrote:
> > On 6/16/07, Pav Lucistnik <pav@freebsd.org> wrote:
> > >Andrew Pantyukhin p????e v so 16. 06. 2007 v 01:20 +0400:
> > >
> > >> > -WRKSRC=                ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > >> > -PKGMESSAGE=    ${WRKSRC}/pkg-message
> > >> > -USE_MOTIF=     yes
> > >> >  USE_BISON=     yes
> > >> >  USE_GMAKE=     yes
> > >> > +USE_MOTIF=     yes
> > >> > +
> > >> > +WRKSRC=                ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > >> > +SUB_FILES+=    pkg-message
> > >>
> > >> PKGMESSAGE defaults to PKGDIR/pkg-message. If we
> > >> have it processed with SUB_FILES, it will end up
> > >> in WRKDIR/pkg-message
> > >
> > >So? His usage of SUB_FILES is perfectly fine.
> >
> > What I can't seem to understand is why PKGMESSAGE is
> > changing from PKGDIR/pkg-message to WRKDIR/pkg-message
> > when SUB_FILES=pkg-message is defined.
>
> Probably because of this:
> bpm, around line 5554:
>
> .for i in pkg-message pkg-install pkg-deinstall pkg-req
> .if ${SUB_FILES:M${i}*}!=""
> ${i:S/-//:U}=   ${WRKDIR}/${SUB_FILES:M${i}*}
> .endif
> .endfor

Hacky, but cool. Unfortunately it was never mentioned
in CHANGES, nor even in commit message (*wink at krion
and flz*). The only docs we have is ports/67151 and
code. Not that it requires any decoding, but a quick
grep discovers over 300 definitions of PKGMESSAGE which
were never needed (that's over a half of all pkg-message
preprocessing cases). So much for innovation.