From owner-cvs-all Fri Sep 14 18:12:34 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 8FB6737B40B; Fri, 14 Sep 2001 18:12:22 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8F1CJi28798; Sat, 15 Sep 2001 02:12:19 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8F1CFd39815; Sat, 15 Sep 2001 02:12:15 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200109150112.f8F1CFd39815@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: obrien@FreeBSD.org Cc: Brian Somers , Josef Karthauser , Garance A Drosihn , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: Proposed patch to log_accum.pl In-Reply-To: Message from "David O'Brien" of "Fri, 14 Sep 2001 14:09:12 PDT." <20010914140912.B98219@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 15 Sep 2001 02:12:15 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Fri, Sep 14, 2001 at 10:29:51AM +0100, Brian Somers wrote: > > > Revision Changes Path > > > 1.108 +6 -5 src/sys/kern/kern_descrip.c > > > 1.1 +123 X src/sys/kern/new_file.c (new) > > > 1.234 X -669 src/sys/kern/dead_file.c (attic) > > > > > > or some other character to pad the column out, but to indicate that > > > there's no value there? > > > > Hmm, I think the X looks odd. > > > > If we have (new) and (attic) then we don't need the Xs. If we have > > the Xs (or even if we have nothing) we don't need the (new) or > > (attic). > > > > Personally I prefer my original suggestion on the basis that it has > > no duplicated information. Parsing is easy, but not as easy as > > having a pad character. > > I assume you'll be fixing the `cvsmail' port then? :-) It doesn't seem to be marked broken here :*P > -- > -- David (obrien@FreeBSD.org) -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message