From owner-freebsd-hackers@FreeBSD.ORG  Thu Feb  3 11:37:01 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 204D4106566C; Thu,  3 Feb 2011 11:37:01 +0000 (UTC)
Date: Thu, 3 Feb 2011 11:37:01 +0000
From: Alexander Best <arundel@freebsd.org>
To: Anonymous <swell.k@gmail.com>
Message-ID: <20110203113701.GA97747@freebsd.org>
References: <20110106014046.GA324@freebsd.org>
	<AANLkTimE74r7579p9pgBEAY__vod=N5=WfgkQ3RE8dzN@mail.gmail.com>
	<20110202172010.GA17563@freebsd.org> <867hdijnkw.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <867hdijnkw.fsf@gmail.com>
Cc: freebsd-hackers@freebsd.org, Sergey Kandaurov <pluknet@gmail.com>
Subject: Re: broken INCLUDE in sys/conf/kern.pre.mk for opensolaris code?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2011 11:37:01 -0000

On Wed Feb  2 11, Anonymous wrote:
> Alexander Best <arundel@freebsd.org> writes:
> 
> > On Wed Feb  2 11, Sergey Kandaurov wrote:
> >> On 6 January 2011 04:40, Alexander Best <arundel@freebsd.org> wrote:
> >> > hi there,
> >> >
> >> > while building target buildkernel with 'clang -v' i noticed a lot of these
> >> > lines:
> >> >
> >> > ignoring nonexistent directory "/usr/subversion-src/sys/contrib/opensolaris/compat"
> >> >
> >> > i checked sys/conf/kern.pre.mk and there's a line refering to a non-existing
> >> > directory:
> >> >
> >> > # ... and OpenSolaris
> >> > INCLUDES+= -I$S/contrib/opensolaris/compat
> >> 
> >> Hi, I just removed that path in r218189.
> >
> > thanks a bunch. :)
> >
> > i might do a 'make universe' build at some point with clang -v in order to
> > check, if there are more cases where non-existing include paths exist in the
> > freebsd src.
> 
> -Wmissing-include-dirs (with -Werror) is there to catch such cases.
> Try to add it to CWARNFLAGS and see if universe build passes.
> 
> Note, clang doesn't support it and it's broken in our gcc but there is a
> simple fix, unfortunately, under gplv3.

could you point me to that gcc gplv3 fix?

i don't quite get why clang is missing this feature. -Wmissing-include-dirs was
set to be a noop in r86059 by chris lattner. since clang -v documents missing
include directories, the functionality already exists within llv/clang.

cheers.
alex

-- 
a13x