From owner-svn-src-all@FreeBSD.ORG Wed Apr 1 12:29:22 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 793F02FB; Wed, 1 Apr 2015 12:29:22 +0000 (UTC) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 076A4665; Wed, 1 Apr 2015 12:29:22 +0000 (UTC) Received: by wgdm6 with SMTP id m6so51508954wgd.2; Wed, 01 Apr 2015 05:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=MMHN7TKJa42fjqmv5uEeIkHfxGS383s6WCjfOTEAUN8=; b=wI9tH4bg2oFql5HrN1e84Cv2cCwiAQsJTmmQkdJ2Ttsc45ngIEtxSKHFVySJJkSVAd yNkWOsTYD52drdyrT74Pg+AwBn8TqCvcu+pv+17YdQCRWo8NP24yyq/BAnCq4kZ1bl8Q RvY7nDEpihrynTo/4IXPDyHR3F+efrk62GkfM/3WQSFmkznNrEIOH6vAYOgNsmbPSDWm JhG0kJk1armHG7m8Dw1kyCKn6bGqr2YBuCEMmCXhIjWqR1oUMMSiMTejJqAkDYfhBR8y UoRgxcPx7D7tRajAoMpqvJ2dLQrI25PptUjnkx4xu3DphnqbUXkpok2/40Y0iAsL5zYR sGvw== X-Received: by 10.180.75.73 with SMTP id a9mr14709591wiw.45.1427891360410; Wed, 01 Apr 2015 05:29:20 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id ea11sm2949572wic.24.2015.04.01.05.29.18 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 01 Apr 2015 05:29:19 -0700 (PDT) Date: Wed, 1 Apr 2015 14:29:16 +0200 From: Mateusz Guzik To: Gleb Smirnoff Subject: Re: svn commit: r280955 - in head/sys: modules/notrandom dev/notrandom Message-ID: <20150401122916.GA10926@dft-labs.eu> References: <20150401113628.GA16649@dft-labs.eu> <20150401114313.GZ64665@FreeBSD.org> <20150401115204.GB16649@dft-labs.eu> <20150401115729.GA64665@FreeBSD.org> <20150401120229.GA2201@dft-labs.eu> <20150401121344.GC64665@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150401121344.GC64665@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 12:29:22 -0000 On Wed, Apr 01, 2015 at 03:13:44PM +0300, Gleb Smirnoff wrote: > Mateusz, > > On Wed, Apr 01, 2015 at 02:02:29PM +0200, Mateusz Guzik wrote: > M> > You can add the seven_region variable to dev/null/null.c and implement > M> > the new device here. Now notrandom.c shares > 50% of code with null.c. > M> > M> Yeah I know, in fact I got most of the code from that driver. > M> > M> I just wanted to have a file with my own copyright in the tree, what's > M> so bad about it. > M> > M> If you feel strongly about it feel free to move it, but I would prefer > M> if you did not. > > You are increasing size of kernel object file merely for a selfish reason. > Sure, but who does not? > While some systems do not care about kernel object size, some embedded do. > Size of source code also matters. You added new code in FreeBSD, that > is likely to be supported for a long time. Of course maintaing two files, > where one is paste of other, requires more efforts than maintaining > single file. > Fair point, but cmon. We can cut IPv6 instead. Net win. > Mateusz, if you keep the momentum, in the next years we will see lots > of files with your copyright. :) There is no reason to create one > just for this. Also, you can legitimately add your name into header of > null.c if you move code of notrandom there. > Yeah, but that's not the same as having my own file, even if I copy-pasted most of it. :( I understand you have concerns, but can we please leave this over the weekend? I'll be happy and maybe it will grow on you in the meantime. I must say this funcionality is so awesome it deserves a separate file regardless of who gets the copyright. -- Mateusz Guzik