From owner-cvs-all@FreeBSD.ORG Thu Aug 24 22:45:34 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B2AA16A4DE; Thu, 24 Aug 2006 22:45:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD4FE43D49; Thu, 24 Aug 2006 22:45:31 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k7OMjUu3070327; Thu, 24 Aug 2006 18:45:30 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Jeremie Le Hen Date: Thu, 24 Aug 2006 18:17:10 -0400 User-Agent: KMail/1.9.1 References: <200608151742.k7FHgE5a035286@repoman.freebsd.org> <20060824214922.GK58048@obiwan.tataz.chchile.org> In-Reply-To: <20060824214922.GK58048@obiwan.tataz.chchile.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608241817.11119.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Thu, 24 Aug 2006 18:45:30 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1726/Thu Aug 24 14:45:50 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: [fbsd] cvs commit [HEAD] src/sys/sys sysent.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2006 22:45:34 -0000 On Thursday 24 August 2006 17:49, Jeremie Le Hen wrote: > John, > > On Tue, Aug 15, 2006 at 05:42:14PM +0000, John Baldwin wrote: > > jhb 2006-08-15 17:42:14 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys sysent.h > > Log: > > Use SYS_AUE_ to include the appropriate audit event identifier > > for syscalls in kld's, even when compiled into the kernel statically. > > Note that since this hardcodes the SYS_ prefix SYSCALL_MODULE_HELPER() now > > only works for native ABI system calls. Those are the only ones that > > used the macro anyway, and I chose to not require a second argument to the > > macro to specify the prefix or audit event directly. > > I am trying to build a module containing a dummy syscall. It uses > SYSCALL_MODULE_HELPER() and now fails to build with the following > error: > % sys_hello.c:73: error: `AUE_NULL' undeclared here (not in a function) > % sys_hello.c:73: error: initializer element is not constant > % sys_hello.c:73: error: (near initialization for `hello_syscall_mod.old_sysent.sy_auevent') > % sys_hello.c:73: error: initializer element is not constant > % sys_hello.c:73: error: (near initialization for `hello_syscall_mod.old_sysent') > > What am I supposed to do ? You should have sys/sysproto.h included (you can only use SYSCALL_MODULE_HELPER for a NOSTD syscall in syscalls.master as it assumes it can get syscallname_args as well as SYS_AUE_syscallname both of which are in sys/sysproto.h). sys/sysproto.h includes the prerequisite header for AUE_NULL. -- John Baldwin