From owner-p4-projects@FreeBSD.ORG  Mon Feb 27 02:36:54 2012
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 52B741065673; Mon, 27 Feb 2012 02:36:54 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 14D24106564A
	for <perforce@FreeBSD.org>; Mon, 27 Feb 2012 02:36:54 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id F16808FC13
	for <perforce@FreeBSD.org>; Mon, 27 Feb 2012 02:36:53 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id q1R2aroG058423
	for <perforce@FreeBSD.org>; Mon, 27 Feb 2012 02:36:53 GMT
	(envelope-from gonzo@FreeBSD.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id q1R2ar1Y058420
	for perforce@freebsd.org; Mon, 27 Feb 2012 02:36:53 GMT
	(envelope-from gonzo@FreeBSD.org)
Date: Mon, 27 Feb 2012 02:36:53 GMT
Message-Id: <201202270236.q1R2ar1Y058420@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	gonzo@FreeBSD.org using -f
From: Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 206956 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Feb 2012 02:36:54 -0000

http://p4web.freebsd.org/@@206956?ac=10

Change 206956 by gonzo@gonzo_thinkpad on 2012/02/27 02:36:02

	Be less verbose, only complain if request register is not valid

Affected files ...

.. //depot/projects/dtrace-mips/sys/cddl/dev/dtrace/mips/dtrace_isa.c#2 edit

Differences ...

==== //depot/projects/dtrace-mips/sys/cddl/dev/dtrace/mips/dtrace_isa.c#2 (text+ko) ====

@@ -92,11 +92,9 @@
 	int i;
 	register_t sp, ra, pc;
 	/* XXX: Fix this ugly code */
-	uintptr_t args[4];
-	int valid[4];
+	uintptr_t args[8];
+	int valid[8];
 
-	printf("frames: %d, arg: %d\n", aframes, arg);
-	db_trace_self();
 	sp = (register_t)(intptr_t)__builtin_frame_address(0);
 	ra = (register_t)(intptr_t)__builtin_return_address(0);
 
@@ -110,16 +108,18 @@
 		: "r" (ra));
 
 	for (i = 0; i <= aframes + 1; i++) {
-		printf("#%d ---> %p\n", i, (void*)pc);
 		if (next_frame(&pc, &sp, args, valid) < 0) {
 			printf("%s: stack ends at frame #%d\n", __func__, i);
 			return (0);
 		}
 	}
-	printf("#%d ---> %p\n", i, (void*)pc);
 
-	if (arg < 4)
-		return args[arg];
+	if (arg < 8) {
+		if (valid[arg])
+			return (args[arg]);
+		else
+			printf("%s: request arg%d is not valid\n", __func__, arg);
+	}
 
 	return (0);
 }