From owner-svn-src-head@FreeBSD.ORG Fri Aug 7 06:57:50 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 43C2E106566C; Fri, 7 Aug 2009 06:57:50 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pz0-f174.google.com (mail-pz0-f174.google.com [209.85.222.174]) by mx1.freebsd.org (Postfix) with ESMTP id E5F648FC1A; Fri, 7 Aug 2009 06:57:49 +0000 (UTC) Received: by pzk4 with SMTP id 4so2411072pzk.7 for ; Thu, 06 Aug 2009 23:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mail-followup-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=RemPFONwts0S31AmGNxzip9fQngmAr05jqrFTFjZn1w=; b=jDlpbrxFxkwRr+cfD5D/1ifQIyO1ubIjGRfOueHkffx/zdm6BQaLhogiRSqlTFmb6w J+lIgM99GMDXq2DkGnxshoc0PP4eC18fJ8pfUHj15ylJ+EOGAb/CO+zqO5+kNohf5MEb YLzIrpcRPsIG1xwSXAhcIOlBzBY8zsNgyTNX8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=DLzEv2YdxnBigobXydgyybWk6Sc7OylIrREoHEpdrShHkkqjYAtgP+2KN6om08suzG cTD7fNV6q9E49VNTJiiPfAdn3V11+v/nx1kz2dZlJqxt2U4u/iZpEdMFxy3M2GFAc4Ab 4BUJMvNtGK6mDguCnrsAuWtg8t6PysKfMNnlc= Received: by 10.114.113.20 with SMTP id l20mr1150237wac.126.1249628269320; Thu, 06 Aug 2009 23:57:49 -0700 (PDT) Received: from doormat.home (c-76-126-210-244.hsd1.ca.comcast.net [76.126.210.244]) by mx.google.com with ESMTPS id j15sm1205033waf.16.2009.08.06.23.57.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 06 Aug 2009 23:57:48 -0700 (PDT) Date: Thu, 6 Aug 2009 23:57:44 -0700 From: Navdeep Parhar To: Hans Petter Selasky Message-ID: <20090807065744.GA23942@doormat.home> Mail-Followup-To: Hans Petter Selasky , Bruce Evans , "M. Warner Losh" , rwatson@freebsd.org, alfred@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <20090802192902.GS47463@elvis.mu.org> <20090804031407.GA8974@hub.freebsd.org> <200908070830.47894.hselasky@c2i.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200908070830.47894.hselasky@c2i.net> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, alfred@freebsd.org, rwatson@freebsd.org, Bruce Evans , svn-src-head@freebsd.org, "M. Warner Losh" Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2009 06:57:50 -0000 On Fri, Aug 07, 2009 at 08:30:45AM +0200, Hans Petter Selasky wrote: > On Thursday 06 August 2009 21:47:16 Navdeep Parhar wrote: > > >> See attached patch. Please test and report back. > > > > > > This patch fixes my problem. The machine is remote and I'm unable > > > to test whether the USB keyboard and keystroke repetition works, but > > > core dumps to a SATA disk are now as fast as they were before > > > r195960. Thanks. > > > > I finally got a chance to try a USB keyboard with ddb, and things did > > not go too well overall. While inside ddb, keystrokes were recognized > > properly and repetition worked too. But after exiting ddb, the > > keyboard wouldn't work - there wasn't any visible response to > > keystrokes. Also, I kept seeing the login prompt continually scroll > > up, as if someone was pressing repeatedly. It certainly > > wasn't me :-) > > > > Are you assuming that a user will not resume normal operation after > > entering the debugger? A panic/reboot isn't the only exit route from > > ddb..... > > > > Simple sequence of steps to reproduce problem: > > ctrl-alt-esc on the USB keyboard > > db> c > > This is like expected. > > Once paniced, USB operation is blocked on the USB controller which the > keyboard belongs to Note that I did not enter ddb on a panic. I entered it voluntarily to take a look at some things. After that I was hoping to continue with business as usual. > board belongs to, because USB does not receive any polling-complete > call, so that it can clean up the state in the USB controller! This > mainly has to do with avoid calling wakeup() during polling. > > To avoid wakeup() calls, USB sets some bits, which must be cleared when > polling is complete, which is currently not done, because USB doesn't know > when polling is complete ... ok. And my question, just like with the previous problem, is: Can something be done about it or are we expected to learn to live with this? All of this is much much better than having *no* USB keyboard with ddb, but there definitely are some kinks to be ironed out. Regards, Navdeep