Date: Wed, 8 Apr 2015 08:54:07 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Mikhail Teterin <mi@FreeBSD.org>, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r383538 - head/databases/sqlitemanager Message-ID: <20150408065407.GF95321@ivaldir.etoilebsd.net> In-Reply-To: <55246A50.2090600@FreeBSD.org> References: <201504072014.t37KEtvQ028188@svn.freebsd.org> <55243D74.7060009@marino.st> <55246A50.2090600@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--GV0iVqYguTV4Q9ER Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 07, 2015 at 06:37:52PM -0500, Bryan Drewery wrote: > On 4/7/2015 3:26 PM, John Marino wrote: > > On 4/7/2015 22:14, Mikhail Teterin wrote: > >> Author: mi > >> Date: Tue Apr 7 20:14:55 2015 > >> New Revision: 383538 > >> URL: https://svnweb.freebsd.org/changeset/ports/383538 > >> > [...] > >> do-install: > >> ${MKDIR} ${STAGEDIR}${WWWDIR} > >> - ${CP} -R ${WRKSRC}/ ${STAGEDIR}${WWWDIR} > >> + ${CP} -Rp ${WRKSRC}/ ${STAGEDIR}${WWWDIR} > >=20 > > ^^^^^ > >=20 > > Why use ${CP} over ${COPYTREE_SHARE} ? > > There was just a big reminder not to install files with ${CP} last week > > on this mail list ... > >=20 > > John > >=20 >=20 > I don't see it. What's wrong with cp? >=20 > --=20 > Regards, > Bryan Drewery >=20 COPYTREE_SHARE enforces the owner (now useless with pkg(8)) and the mode to= be the proper expected ones in packages While CP is blindly copying Best regards, Bapt --GV0iVqYguTV4Q9ER Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlUk0I8ACgkQ8kTtMUmk6Ex7IQCgvyQgHRJWNI5/CqmWidWy41ON 10AAoJ0ZZNPCKLK3XRxBXHreVgIu7yDj =xN3R -----END PGP SIGNATURE----- --GV0iVqYguTV4Q9ER--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150408065407.GF95321>