From owner-freebsd-hackers@FreeBSD.ORG Tue May 10 13:39:27 2011 Return-Path: Delivered-To: hackers@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D72B1065676; Tue, 10 May 2011 13:39:27 +0000 (UTC) (envelope-from gabor@kovesdan.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id 29C0B8FC17; Tue, 10 May 2011 13:39:27 +0000 (UTC) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 7327C14E5462; Tue, 10 May 2011 15:39:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at server.mypc.hu Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2Oxknnx1Kbcd; Tue, 10 May 2011 15:39:24 +0200 (CEST) Received: from [193.137.158.225] (unknown [193.137.158.225]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id 166CC14E533D; Tue, 10 May 2011 15:39:24 +0200 (CEST) Message-ID: <4DC9400A.8080304@kovesdan.org> Date: Tue, 10 May 2011 14:39:22 +0100 From: Gabor Kovesdan User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; pt-PT; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Bakul Shah References: <4DC7356C.20905@kovesdan.org> <20110509011709.5455CB827@mail.bitblocks.com> <4DC74546.1060902@kovesdan.org> <20110509014938.EE292B827@mail.bitblocks.com> <20110509061334.A62EAB827@mail.bitblocks.com> <20110509215146.GA18135@zim.MIT.EDU> <20110510001518.2C855B827@mail.bitblocks.com> In-Reply-To: <20110510001518.2C855B827@mail.bitblocks.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 10 May 2011 15:21:37 +0000 Cc: "Pedro F. Giffuni" , David Schultz , hackers@FreeBSD.ORG, Brooks Davis , Zhihao Yuan Subject: Re: [RFC] Replacing our regex implementation X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2011 13:39:27 -0000 Thanks to all for the valuable comments. I've decided to continue the work with TRE because - Many people don't like the idea of adding C++ code into libc - I'm not very skilled in C++ However, in a later phase of development, I think re2 may be a good source of ideas in optimizing the performance. For now, I think if the new code without optimizations is at least as fast as the old regex code, that's fine. Imho, the motivation of replacing it is not just the performance but also the fact it is outdated code and not maintained any more and also the lack of wide character support. Once it is feature-complete to replace the old code, we can start thinking of optimizations. And as proposed, I'll separate those from libc for now and later I can propose some changes to the TRE maintainer. Gabor