From owner-svn-src-all@freebsd.org Tue Apr 19 20:38:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D9B9B15366; Tue, 19 Apr 2016 20:38:22 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x230.google.com (mail-ig0-x230.google.com [IPv6:2607:f8b0:4001:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D9FEE1F50; Tue, 19 Apr 2016 20:38:21 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x230.google.com with SMTP id f1so110748113igr.1; Tue, 19 Apr 2016 13:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=V1jVxVU3h04hul5GFPYgJlQ/+aqWicdmVRomwrEmJOo=; b=XTNtBf+WEjOcsXNAibz/47kVWPnijQU9EhTbvAIy4lBQBvLT36QPREABPIfSud3tZM vuK1XCnaFwqJSdefLxYwy7xEv1g/qR4j22ZjHIJkdk6YfpwjwzVRTQgUytM8x163be2P TIPolHLh7gkS00jWif4vPBOoDRlHc+SNoUy2DLn9rrKRQ1A0Mk5iGWfl4tejjQ6Al3b+ kcb/gp1mbXZjKTQFEwZcx1DFSvGeEv4hFED4tF1lFrKEXubEmUW8kmshLmkj2vSIyarN HGcFJTFs11LFJrNdVgRoDcCjYzZNzuUiDdzszd/aBME78ggn6EQOn/W1kd5z1LB+l4ND ny4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=V1jVxVU3h04hul5GFPYgJlQ/+aqWicdmVRomwrEmJOo=; b=EmCjxOi/tg9daoLJBGDwsgrPypsObPpzhhw62Ojdsq4vtKppr1XcIJcud+eOoZjGdd 6rSJvq1ODfhGn4iAr1YHlxq9aIwKyda9e+obwZjEzJLDOGyKYhtJ6X6qcGXpoXbfJOEj X5Qyd9+Lw3ZfGTWar4aoDh9qDp81aesvCxAqPmBDRYKjY/Xgm5rT9St16aWX/6MMDggH Y7DuvPHXccT6E4QQdMBZNSdM6/vM8RrD4d1GTDq3krbZijD+nL0GS6vWkMxK93dU4yq/ uzIVNkPeAMPx7BKgHZnnAaDC6Tssyk2yV0mxfWQiTDmtCGm5xWLummfwSrYZqwa48MdZ CTKw== X-Gm-Message-State: AOPr4FXz9HGtdYITds/E1UBm3wVqR91SHcpz00dHa4TU7d1rI8bBw2UuvYnJ5RmdSFmOa7V9D6PiZxKsEeihPg== MIME-Version: 1.0 X-Received: by 10.50.57.199 with SMTP id k7mr5834289igq.61.1461098300300; Tue, 19 Apr 2016 13:38:20 -0700 (PDT) Received: by 10.36.14.19 with HTTP; Tue, 19 Apr 2016 13:38:20 -0700 (PDT) In-Reply-To: References: <201604191539.u3JFdkHx048678@repo.freebsd.org> <20160419171243.GA30453@bsdpad.com> <1461097280.1232.34.camel@freebsd.org> Date: Tue, 19 Apr 2016 13:38:20 -0700 Message-ID: Subject: Re: svn commit: r298274 - head/sys/dev/spibus From: Adrian Chadd To: Patrick Kelsey Cc: Ian Lepore , Juli Mallett , Ruslan Bukin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 20:38:22 -0000 On 19 April 2016 at 13:37, Patrick Kelsey wrote: > > > On Tue, Apr 19, 2016 at 4:21 PM, Ian Lepore wrote: >> >> On Tue, 2016-04-19 at 13:17 -0700, Juli Mallett wrote: >> > Patrick Kelsey offered an mmcspi driver for FreeBSD, but nobody >> > seemed >> > interested. I know of one proprietary branch of FreeBSD using it. >> > You might poke him if you want to know how he dealt with this, and if >> > you want to commit his driver. >> > >> >> Patrick is a committer, maybe he should just commit it. :) > > > What I believe originally held up that driver being committed (by others - > this was before my commit bit) was that I relied on some out-of-tree spibus > changes Luiz had made (as I recall, mainly being able to reserve the SPI bus > for multiple transactions), and getting those into the tree would have > required updating/testing other existing SPI drivers, based on feedback I > received at the time. All I had was the RB450G that I developed and tested > the driver with, so I really couldn't address that issue, and then work took > me in some other direction entirely. Some or all of these spibus changes > that I relied on might now be in the tree, I'm not sure offhand. I am sure > though that a huge stack of other things I need to get through has > chronically kept me from updating that driver to current and retesting. > > When I wrote that driver, I put a lot of effort into testing it against as > many different cards as I could obtain at the time - I believe 30 or so in > total, all the details are in the code that was posted to the list back > then. I encountered a number of strange/unexpected behaviors in that set of > cards, and all of that hard-won knowledge is in that driver, including a > much less complex fix for a shifted-response-data issue than you will see if > you look at the Linux mmcpsi driver (as I recall, the Linux driver has code > to arbitrarily bit-shift card response data, and to detect when that should > be done, but it turns out that can be avoided entirely by inserting idle > cycles in the right place when sending the command). Well, we should add the SPI bus reservation code and churn stuff as needed. I think that'd be a great addition. Do you have a patchset somewhere? -adrian