From owner-freebsd-arm@freebsd.org Sun Oct 13 18:55:08 2019 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42B67139D83 for ; Sun, 13 Oct 2019 18:55:08 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46rrV31mk4z4QCx for ; Sun, 13 Oct 2019 18:55:06 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id x9DIsgZC076976 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 13 Oct 2019 11:54:43 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id x9DIsg9W076975; Sun, 13 Oct 2019 11:54:42 -0700 (PDT) (envelope-from jmg) Date: Sun, 13 Oct 2019 11:54:42 -0700 From: John-Mark Gurney To: Thomas Skibo Cc: freebsd-arm@freebsd.org, Emmanuel Vadot Subject: Re: PINE64+ 2GB - with U-Boot SPL 2019.10 - bootaa64.efi do not find UFS partition Message-ID: <20191013185442.GR96402@funkthat.com> Mail-Followup-To: Thomas Skibo , freebsd-arm@freebsd.org, Emmanuel Vadot References: <9840C5F9-64F8-4415-A24E-E62507F14C8D@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9840C5F9-64F8-4415-A24E-E62507F14C8D@yahoo.com> X-Operating-System: FreeBSD 11.0-RELEASE-p7 amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Sun, 13 Oct 2019 11:54:43 -0700 (PDT) X-Rspamd-Queue-Id: 46rrV31mk4z4QCx X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [-1.32 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.53)[ip: (-1.37), ipnet: 208.87.216.0/21(-0.69), asn: 32354(-0.55), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; FREEMAIL_TO(0.00)[yahoo.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Oct 2019 18:55:08 -0000 Thomas Skibo via freebsd-arm wrote this message on Fri, Oct 11, 2019 at 08:50 -0700: > > > U-Boot SPL 2019.10 (Oct 10 2019 - 18:05:29 +0200) > > DRAM: 2048 MiB > > Trying to boot from MMC1 > > NOTICE: BL31: v2.0(release): > > > > >> > > FreeBSD EFI boot block > > > > Loader path: /boot/loader.efi > > > > Initializing modules: ZFS UFS > > Load Path: /efi\boot\bootaa64.efi > > Load Device: > > /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/SD(0)/SD(0)/HD(1,0x01,0,0x403b,0x20000) > > Probing 3 block devices...... done > > ZFS found no pools > > UFS found no partitions > > Failed to load '/boot/loader.efi' > > panic: No bootable partitions found! > > ## Application terminated, r = 1 > > > I???ve been looking into this. As of u-boot v2019.10, there are some extra checks in efi_disk_read_blocks() and now it will fail with EFI_INVALID_PARAMETER if the buffer isn???t aligned. In my case, efi_disk_read_blocks() was called with a buffer address of 0x1da06040 but with this->media->io_align = 512. (See lib/efi_loader/efi_disk.c line 125.). Evidently,loader.efi is making disk calls with unaligned buffers but it wasn???t an issue until these checks were added. That???s as far as I got debugging this. This would also likely fix the issues I'm seeing w/ the latest RockPro64. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."