From owner-svn-src-all@FreeBSD.ORG Wed Nov 10 19:33:30 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 855CA1065695; Wed, 10 Nov 2010 19:33:30 +0000 (UTC) (envelope-from gljennjohn@googlemail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id A785E8FC08; Wed, 10 Nov 2010 19:33:29 +0000 (UTC) Received: by bwz2 with SMTP id 2so1092374bwz.13 for ; Wed, 10 Nov 2010 11:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:reply-to:x-mailer:mime-version :content-type:content-transfer-encoding; bh=Ntja3M77eLy7xhPLggeWeRZt8Ea0Xeq4mJuBhUjoWwI=; b=ppC8AI/VYg342QxZmjJy/JqVzQuU4kRNrU8Z+nkIvLbVdWZ7YdvVAkspqdB3WYVk59 AglpF7i4KRJWU77utdgKNKzbLQA5ILF5kvKWS5VKshnArw3vAp0lp2wN0JlhCSEqc71C zQV6gCuXzbtbUVDqoRKT4rNIP/PX8ZcQjnnIA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :x-mailer:mime-version:content-type:content-transfer-encoding; b=qdAPkHZjMmU0KlulMLHsgINOE8gQYnihNjCGMHVxkXGAdiH1KJNjAKkBpqm6wcdKIR 62ubi+yLvWfx/FeA8IuKZcoLNn77Rlgzsy11916LOXi7JLVb6FjVQ4vdimsTh61gZHbT v1zNXHUjiGTTZKt6czTyeH+3EhxxJh7b+BzAI= Received: by 10.204.102.2 with SMTP id e2mr8383910bko.24.1289417403278; Wed, 10 Nov 2010 11:30:03 -0800 (PST) Received: from ernst.jennejohn.org (p578E31C5.dip.t-dialin.net [87.142.49.197]) by mx.google.com with ESMTPS id d27sm552628bkw.2.2010.11.10.11.30.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Nov 2010 11:30:01 -0800 (PST) Date: Wed, 10 Nov 2010 20:29:59 +0100 From: Gary Jennejohn To: Marcel Moolenaar Message-ID: <20101110202959.44759eae@ernst.jennejohn.org> In-Reply-To: <48E80281-F1B2-46A7-90F8-426D9D5CBBD5@mac.com> References: <201011101438.oAAEcqDQ022127@svn.freebsd.org> <48E80281-F1B2-46A7-90F8-426D9D5CBBD5@mac.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.7; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215088 - head/sys/geom/part X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gljennjohn@googlemail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 19:33:30 -0000 On Wed, 10 Nov 2010 09:40:03 -0800 Marcel Moolenaar wrote: > > On Nov 10, 2010, at 6:38 AM, Andrey V. Elsukov wrote: > > > Author: ae > > Date: Wed Nov 10 14:38:51 2010 > > New Revision: 215088 > > URL: http://svn.freebsd.org/changeset/base/215088 > > > > Log: > > In r212554 name of G_PART_PARM_GEOM and G_PART_PARM_PROVIDER > > ctlreq parameters was changed to "arg0". Fix the last place where > > it is used. > > A regression for sure. Nothing worse than having a good > and clear interface messed up by a lousy implementation > of geom(8)... > > *sigh* > I wondered about this change myself. Juat because it's called arg0 in the declaration doesn't mean that the callers have to use it. Maybe ther was a good reason for it which I don't understand. Consistency, I suppose. -- Gary Jennejohn