From owner-svn-src-head@freebsd.org Thu Mar 16 04:44:06 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C22CBD0D35B; Thu, 16 Mar 2017 04:44:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x234.google.com (mail-pg0-x234.google.com [IPv6:2607:f8b0:400e:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 839A215DF; Thu, 16 Mar 2017 04:44:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x234.google.com with SMTP id g2so19020449pge.3; Wed, 15 Mar 2017 21:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=KpzY+bgBPdTmx0I7doD8Ke/bQmFGeTez8doxBa5IwPw=; b=SDS/KOIJtpLP8Y52QlWvYEELYVaPYh9sfiMDwSsncNlz3+DSOTQyMtU9cuDwQFVQ+R qntrf9boERL7kodku7pELR/sa7VT7TkD5duS4V/TUde0C4yJSHuqaHmBIXa3K2O/yhRA J2XAVDb1Bg7FtgDXnIK5NBvBNVPOqyns3/b53N4DIzzcPUXMFTzLIf13Piw5se1LCzeP jE3Zlr7u2wFkzZLhdUNgYJg5zJiGgaL8oVtI6CresdMIHFaEn6WEduRyMYj466LVtaf9 ORtsqvbMDotnJsGHzKzWszY5YrvMNndxeQ4fsDIs2bL65SIaGrnAaDLGPk8emJVB+ehp 5Wrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=KpzY+bgBPdTmx0I7doD8Ke/bQmFGeTez8doxBa5IwPw=; b=By75b0rKAoVY/raDLer64iy+bf+ZDgd72O79JV9y1gWS0YcR7rH6ytUPz0ghtNvUtS Aar/6MDl+tDwmitqgzYFYWy62ZYrtZgv/7Z34GAKXm+VWKOwrwgbkmC5+oWA77naCvGo PExher1FXprIZYjFRNhQ3RcABKb0VNg1FErQ0dbH/gUR5IaLLN3Di5ZTSGpn3ChVPAgb PcqfhVYGULhDVimBJpZ7X6yCcEapCy89uS0nXpbwB+Yw3Bd7KrG+dSwj8e6l/+DTR1KY QSb0wnAKY8GWu91vi0LBpqA/WeChio9L1FwoTr7S87nDRp8JE3VNYqaOrxybIOTiVVIN eSnQ== X-Gm-Message-State: AFeK/H1oYu5PNAOIEGYqS4ETFTVGDnciuOeOANvgBxbr14voZxLA8WQTfc4P48spOZ8a9w== X-Received: by 10.98.66.155 with SMTP id h27mr7810097pfd.182.1489639446075; Wed, 15 Mar 2017 21:44:06 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id t70sm6889175pfe.64.2017.03.15.21.44.04 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Mar 2017 21:44:05 -0700 (PDT) Subject: Re: svn commit: r315360 - head/lib/libkvm Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_4FE0695C-43BB-4832-800C-D8D5F039D0B5"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Wed, 15 Mar 2017 21:44:03 -0700 Cc: Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <58A53702-FFF6-45E7-ACCD-9B776530064E@gmail.com> References: <201703160231.v2G2VgxK082641@repo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2017 04:44:06 -0000 --Apple-Mail=_4FE0695C-43BB-4832-800C-D8D5F039D0B5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Mar 15, 2017, at 21:32, Warner Losh wrote: >=20 > On Wed, Mar 15, 2017 at 8:31 PM, Ngie Cooper wrote: >> Author: ngie >> Date: Thu Mar 16 02:31:42 2017 >> New Revision: 315360 >> URL: https://svnweb.freebsd.org/changeset/base/315360 >>=20 >> Log: >> Return NULL instead of 0 on failure in _kvm_open, kvm_open{,2,files} >>=20 >> This is being done for the following reasons: >> - kvm_open(3), etc says they will return NULL. >> - NULL by definition is (void*)0 per POSIX, but can be redefined, >> depending on the compiler, etc. >=20 > No, it can't. The C language requires all integral expressions that > evaluate to zero to convert to the NULL pointer. This is independent > of the internal representation of the NULL pointer. >=20 > So this change is an NOP for all compilers. It's a good STYLE change. Someone made an argument a few weeks ago about NULL being definable as a = non-zero value on some esoteric architectures or OSes. I agree though, this is largely stylistic/pedantic for a good cause. If = someone set NULL to something non-zero in value, they would be looking = for pain :). -Ngie --Apple-Mail=_4FE0695C-43BB-4832-800C-D8D5F039D0B5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYyhgUAAoJEPWDqSZpMIYVu3IQAKcnuoyftDZrW4T3DVCcT36D 4vprKNb/fVJ0OH9PororOFmw9F/FEHxC4z5FF+sxMsaL9zgSrS30nO7zWpajtSid zb3tcYVGrWm5W5eXPXx0fmpNMrOOPHSSgBrQFAb9t6XNfJC8RlKITNDhMpypX6WC DOywWzW1G/LqtmMemPufw4UmQO7sjYS+gTUPzBkffGvhhjS+HNqIcpgyklBpP/li rHM+HB1flh+mpW6PUO8tdHoI1GxPvKdTpOdDFV6N4nmx4MX1AIz4hlbonG6aAjiR I6D1uzD7oEXGcvSmDriv5c4z3Dc92fZRLKnbDHOGy6P0Cqo5LozWFw2682vJX/vh H2ByhDkZGUwU5IDFnGk1/gr80t+3E0iFmjUSeK4BSkQ6KNRn80WBovLPbdG5fnrJ R44R3fYDbdYdb4FzgJu+qxsNZG7wmpDrpdFUhwBRqJLSywTW6QCySWpPvJd77YV3 KwFLDkkW+b6zaVwBML7KT5ZMIibFM89OB9mJbG/o3whUCOBqbUa0ZfRvY+oNvQIt x9Qs1rv/0e5G5BFN46Am14r5bO9BFTXRzIqMYZOGOYqsA9noJacQa5tirTpncxxO B1IyZsRgyJR50BbHBOVhmrZ5PyWGKrn+Yp9dqgJ7OyITTAcy7/xLXGpT1whwetDI HTQ+AoYgHU86iqAlQGTY =UfoL -----END PGP SIGNATURE----- --Apple-Mail=_4FE0695C-43BB-4832-800C-D8D5F039D0B5--