Date: Wed, 31 Mar 2004 11:38:28 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Max Laier <mlaier@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/authpf Makefile Message-ID: <20040331193828.GA54975@xor.obsecurity.org> In-Reply-To: <200403311742.i2VHgOc2040039@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Wed, Mar 31, 2004 at 09:42:24AM -0800, Max Laier wrote:
> mlaier 2004/03/31 09:42:24 PST
>
> FreeBSD ports repository (src committer)
>
> Modified files:
> security/authpf Makefile
> Log:
> Fix a long standing typeo in Makfile .if and bump PORTREVISION.
>
> PR: 64982
> Submitted by: Rik
> | .if defined(WITH_ALTQ) && (${WITH_ALTQ} == "yes")
FYI, testing for "yes" is non-standard. The standard behaviour is
just to test for existence of the variable, not value, so WITH_FOO=bar
works just as well as WITH_FOO=yes or even WITH_FOO=no [1].
Kris
[1] At first sight the latter might be confusing, but it's less
confusing to learn up-front than to be confused why 99% of the
thousands of WITH_FOO instances don't respect it.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAax40Wry0BWjoQKURAuNUAJ9AJplgcaVROsCGhYgef0wEClchDwCfSS7w
IZQhMeNJmFlCHSAGkShfU2c=
=w5Oj
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040331193828.GA54975>