From owner-cvs-all@FreeBSD.ORG  Wed Mar 31 11:38:30 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3DAA016A4CE; Wed, 31 Mar 2004 11:38:30 -0800 (PST)
Received: from mtaw6.prodigy.net (mtaw6.prodigy.net [64.164.98.56])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2AB6343D1F; Wed, 31 Mar 2004 11:38:30 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(06e498fe98659ddbabd7262a2b1eaecc@adsl-67-115-73-128.dsl.lsan03.pacbell.net
	[67.115.73.128])
	by mtaw6.prodigy.net (8.12.10/8.12.10) with ESMTP id i2VJbOYR001604;
	Wed, 31 Mar 2004 11:37:24 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id AE34751A72; Wed, 31 Mar 2004 11:38:28 -0800 (PST)
Date: Wed, 31 Mar 2004 11:38:28 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Max Laier <mlaier@FreeBSD.org>
Message-ID: <20040331193828.GA54975@xor.obsecurity.org>
References: <200403311742.i2VHgOc2040039@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9"
Content-Disposition: inline
In-Reply-To: <200403311742.i2VHgOc2040039@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/security/authpf Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Mar 2004 19:38:30 -0000


--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 31, 2004 at 09:42:24AM -0800, Max Laier wrote:
> mlaier      2004/03/31 09:42:24 PST
>=20
>   FreeBSD ports repository (src committer)
>=20
>   Modified files:
>     security/authpf      Makefile=20
>   Log:
>   Fix a long standing typeo in Makfile .if and bump PORTREVISION.
>  =20
>   PR:             64982
>   Submitted by:   Rik

> |  .if defined(WITH_ALTQ) && (${WITH_ALTQ} =3D=3D "yes")

FYI, testing for "yes" is non-standard.  The standard behaviour is
just to test for existence of the variable, not value, so WITH_FOO=3Dbar
works just as well as WITH_FOO=3Dyes or even WITH_FOO=3Dno [1].

Kris

[1] At first sight the latter might be confusing, but it's less
confusing to learn up-front than to be confused why 99% of the
thousands of WITH_FOO instances don't respect it.

--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAax40Wry0BWjoQKURAuNUAJ9AJplgcaVROsCGhYgef0wEClchDwCfSS7w
IZQhMeNJmFlCHSAGkShfU2c=
=w5Oj
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--