Date: Wed, 18 Dec 2013 00:13:52 GMT From: John Marino <freebsd@marino.st> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/184952: x11-servers/xorg-server: Slave port makefiles all have same error Message-ID: <201312180013.rBI0Dq3R035356@oldred.freebsd.org> Resent-Message-ID: <201312180020.rBI0K0B7057055@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 184952 >Category: ports >Synopsis: x11-servers/xorg-server: Slave port makefiles all have same error >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Dec 18 00:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Marino >Release: >Organization: >Environment: >Description: I reported this issue over IRC but apparently it has been forgotten. I am writing this down via PR officially now. x11-servers/xorg-nestserver x11-servers/xorg-vfbserver x11-servers/xephyr are all slave ports of x11-servers, and all have the same issue: They each have this line: .include <bsd.port.options.mk> As these are slave ports, there are no options defined. So at the very best, it's a useless line that needs cleaning up. However, it actually causes duplicate loading of Makefile.* which breaks dports (it causes patches to be applied twice). Please remove these extraneous includes >How-To-Repeat: >Fix: remove ".include <bsd.port.options.mk>" line from each of these three ports. >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312180013.rBI0Dq3R035356>