From owner-svn-ports-head@freebsd.org Wed Feb 20 06:38:05 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AB0E14E7C32; Wed, 20 Feb 2019 06:38:05 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EB09C8F01D; Wed, 20 Feb 2019 06:38:04 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x52b.google.com with SMTP id r124so11362921pgr.3; Tue, 19 Feb 2019 22:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x4wPr+0yrvpu4s9wiqgUdNpNykKP4+jPIb6/shp+4r4=; b=AmnKS7qKKfO9/lFODlPPXtDPezvjBKjLJa4dig5KIcHhdvBQ6615R00ngBHYTyIvyA dsgs1B2aoiyE3khdl01eCuI7CIORoi9JIZJFwelRDDzsv3v5hs3wcrBB0BKdPeywUdI/ O3XsrkoABYgE9ukUJosBaoMHrYuKls3x4OlUFXZ1hQo97OSmBJx6JoEaSXqYadKaGerl N08IPU5rl1Vjfqj9u+l5TbEHgVYcViGYLotQnaOdqKJkq8VNYUJdQdL4irDsc8Jm404J BOO3fWwsT++83lvSDT95ogNWMHeLtjMTJ5fZPSJhH+rGzfFP4zdufKD80p05m3RW/IjU liZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=x4wPr+0yrvpu4s9wiqgUdNpNykKP4+jPIb6/shp+4r4=; b=YhGj9yh0Cic706lS2+5eTuwJz+Rcy5faOIg7XLaKnKVfecW/5EbAupd4SO7seoUmLv NsuJK6vTYM+zDpfw5M8mJLjNRUFEuCznVaBHl9lF+4XljEyxA/q5/bzNdSEw20EfbbVe 8ekpSmRJp1yrg1rnyOrC+3mBfs7IfnoKq6QM56H9LFySm4vhjtjf8I2JyhcqmKyaA+mX vpkaQ64+mBovLJQtSe/lYAgXZN6V0eY3IVXSYjnkGyXnPNDWrerp+SrVAFA0EKqW4uqL 5bnvzzqTPadwmfADAiMDPRJWW2lOkPPBZ/DqZxHBTT4/Z8GK0KG+qFAxRQE0YTbCQYkm vN0A== X-Gm-Message-State: AHQUAuZSwSj7+5GRRwIQQzpzlslbQc+5OonnS9ZRbWRV6e5YnSVFBR2o JwxWWUpG5LHzsrIG2SJ+PDRwRHcE X-Google-Smtp-Source: AHgI3IZgM+j41eOHzlPtYcwUQlvYo2wchzx4ss5lI7aSs6zqpeYGLbKQ2UJ258su2hpdqHHyJiLLLw== X-Received: by 2002:a62:9917:: with SMTP id d23mr34340361pfe.88.1550644683371; Tue, 19 Feb 2019 22:38:03 -0800 (PST) Received: from [192.168.1.105] (119-18-15-55.77120f.syd.nbn.aussiebb.net. [119.18.15.55]) by smtp.gmail.com with ESMTPSA id h10sm23505785pgn.11.2019.02.19.22.38.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 22:38:02 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r493407 - head/graphics/xpdf4 To: Tobias Kortkamp , Cy Schubert Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joe Marcus Clarke References: <201902200614.x1K6Ev15089326@repo.freebsd.org> <20190220063422.GA18880@urd.tobik.me> From: Kubilay Kocak Message-ID: <4a641dc1-0337-00ee-55a2-80cb56263c27@FreeBSD.org> Date: Wed, 20 Feb 2019 17:37:58 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Thunderbird/66.0 MIME-Version: 1.0 In-Reply-To: <20190220063422.GA18880@urd.tobik.me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EB09C8F01D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.938,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 06:38:05 -0000 On 20/02/2019 5:34 pm, Tobias Kortkamp wrote: > On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote: >> Author: cy >> Date: Wed Feb 20 06:14:57 2019 >> New Revision: 493407 >> URL: https://svnweb.freebsd.org/changeset/ports/493407 >> >> Log: >> Remove whitespace in USE_QT, otherwise qmake_build is ignored. >> >> Reported by: Paul Beard >> >> Modified: >> head/graphics/xpdf4/Makefile >> >> Modified: head/graphics/xpdf4/Makefile >> ============================================================================== >> --- head/graphics/xpdf4/Makefile Wed Feb 20 04:50:53 2019 (r493406) >> +++ head/graphics/xpdf4/Makefile Wed Feb 20 06:14:57 2019 (r493407) >> @@ -27,8 +27,7 @@ SUB_FILES= xpdf-man.conf >> >> USES= compiler:c++11-lang cmake localbase:ldflags \ >> desktop-file-utils qt:5 >> -USE_QT= buildtools_build,concurrent,core,gui,network,printsupport,\ >> - qmake_build,svg,widgets >> +USE_QT= buildtools_build,concurrent,core,gui,network,printsupport,qmake_build,svg,widgets > > Next step: Replace the , with spaces to actually add Qt dependencies > to the port. Check with build-depends-list, run-depends-list, > stage-qa. Currently the port has no Qt 5 dependencies and it fails > to build in Poudriere: > > ===> Checking for items in pkg-plist which are not in STAGEDIR > Error: Missing: libexec/xpdf/xpdf > Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz > ===> Error: Plist issues found. > If USE_* values are never comma-separated (always space separated), sounds like a good portlint check to have. If we have some comma-separated support framework bits (I didn't check), maybe we should standardize on not doing so